Closed Bug 1171041 Opened 5 years ago Closed 5 years ago
Regression: Tab count button becomes unresponsive for a second or two after opening a new tab
Currently after opening a tab the tab count button to open the tab drawer becomes unresponsive for a second or two e.g, you want to open another tab quickly. Tapping the button does nothing until something in the background finishes.
Tried a couple things to slim down the CPU cycles when the transition finishes. Let me know how this feels - I think it's feeling better now.
Comment on attachment 8614849 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/554 These changes look good to me, though I'm not sure if they'll fix this. I've actually noticed this before too (thanks Aaron for filing), and I think it's related to the clone button we create at  during the animation. It doesn't have a click listener, so it's untappable while it's active. A simple solution might be to just attach the same click listener to the cloned view? It's a little strange that the animation is lasting as long as it is since I don't actually see any movement during this period.  https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/URLBarView.swift#L301
Attachment #8614849 - Flags: review?(bnicholson) → review+
Good catch -- I do notice the lag is longer whenever opening a new tab and it looks like it's probably because of the cloned button. I'll update the PR to add the selector to the fake button as well.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attachment #8614849 - Flags: feedback?(aaron.train) → feedback+
You need to log in before you can comment on or make changes to this bug.