1171063 - Avoid setting nonexistent --authentication-file, again

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Steve Fink [:sfink] [:s:]]

In bug 1161794, I prevented passing --authentication-file if no such file exists, to allow unauthenticated use of the tooltool server (if that was all that was needed for a mozharness script.) Bug 1155238 added a new unconditional --authentication-file that broke my fix.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Avoid setting nonexistent --authentication-file, again

The confusing part is that the two files passed come from different code, and I don't know what the difference is. developer_mode uses get_credentials_path(), while the uncondtional one uses self._get_auth_file(). I doubt it accepts multiple paths, some I'm guessing one of these should go away or they should be merged. But I don't know enough about them to to do this. This patch eliminates get_credentials_path(), which works for me, but that doesn't prove anything because my use case requires neither of them to be used.

I'm not sure whether to give this to Armen or Dustin. /me flips coin

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8614737 [details] [diff] [review]
Avoid setting nonexistent --authentication-file, again

Review of attachment 8614737 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozharness/mozilla/tooltool.py
@@ -51,5 @@
>                  cmd = [tooltool[0]]
>              else:
>                  cmd = [self._fetch_tooltool_py()]
> -            if os.path.exists(get_credentials_path()):
> -                cmd.extend(["--authentication-file", get_credentials_path()])

Looks good -- get_credentials_path is for ~/.mozilla/credentials.cfg, which contains LDAP credentials rather than a relengapi token.

Comment 3

[Armen [:armenzg]]

Comment on attachment 8614737 [details] [diff] [review]
Avoid setting nonexistent --authentication-file, again

Review of attachment 8614737 [details] [diff] [review]:
-----------------------------------------------------------------

We don't need that old approach anymore.

We still need credentials for pvtbuilds (not tooltool).

Comment 4

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/build/mozharness//rev/4326760e943d