1171219 - Support for badged toolbarbuttons with panels

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

I have a problem where a toolbarbutton with type="panel" isn't allowed to include a badge. This patch seems to fix the problem.

Comment 1

[:Gijs (out for now; he/him)]

Comment on attachment 8614931 [details] [diff] [review]
patch

Review of attachment 8614931 [details] [diff] [review]:
-----------------------------------------------------------------

Neil, does this look right to you? I kind of wish we could do this without yet another binding.

Bill, is there some reason you didn't keep the hbox/vbox structure inside the toolbarbutton[type="menu"]'s structure? Also, have you tested what this looks like in practice, ie if the styling all works out?

Comment 2

[[e-mail]]

Comment on attachment 8614931 [details] [diff] [review]
patch

Seems reasonable to me, but I'd add support for [type="menu"] too for consistency, unless there's a particular reason not to.

Comment 3

[[e-mail]]

(In reply to Gijs Kruitbosch from comment #1)
> Neil, does this look right to you? I kind of wish we could do this without
> yet another binding.
I guess the way to go there would be to wrap the <img> in a box in the base binding, then when you want a badge, add a binding to the wrapper box that provides the badge.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd26eba375ae

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fd26eba375ae