Closed Bug 1171229 Opened 10 years ago Closed 10 years ago

The title bar shows "undefined- DXR Search" for dynamic searching

Categories

(Webtools Graveyard :: DXR, defect)

Product:
Webtools Graveyard
Component:
DXR
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox41 --- affected

People

(Reporter: xidorn, Assigned: new_one)

References

Details

(Whiteboard: es)

In DXR 2.0 (dxr.allizom.org), when inputing to the search box on the top of the page, the title bar doesn't display the keywords correctly. Instead, it shows "undefined- DXR Search".
Looks like document.title is set from data.query, but that value is undefined. Should be a one line fix; I'll take the bug and put something up.
Assignee: nobody → peter.elmers
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
The title bar still shows undefined for me. Has this change landed on dxr.allizom.org? If so, probably I should reopen this bug?
Flags: needinfo?(peter.elmers)
(In reply to Xidorn Quan [:xidorn] (UTC+12) from comment #3) > The title bar still shows undefined for me. Has this change landed on > dxr.allizom.org? If so, probably I should reopen this bug? The bug should be fixed by the referenced commit, but dxr.allizom.org has not been rebuilt yet.
Flags: needinfo?(peter.elmers)
Commit pushed to master at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/3bf7596b9b9aaa031be81c0836b0e6f2ece71f59 Fixes bug 1171229. Correctly update title on dynamic searches.
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.