Closed Bug 1171230 Opened 4 years ago Closed 4 years ago

Include parent window ID in nsIWebProgress

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED INVALID
Tracking Status
firefox41 --- affected

People

(Reporter: billm, Assigned: billm)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This is a useful feature to have, particularly for e10s. It's needed so we can implement the semantics of Chrome's webNavigation API for extensions.
Attached patch patchSplinter Review
These are the platform changes.
Attachment #8614943 - Flags: review?(bugs)
Attached patch toolkit-patchSplinter Review
Here's the toolkit patch.
Attachment #8614944 - Flags: review?(felipc)
I don't quite understand the need of this.
And what should parentWindowID be in case window->GetParent() returns the window itself?
Comment on attachment 8614943 [details] [diff] [review]
patch

I have the gut feeling this isn't quite what you mean, especially since
DOMWindowID can be the same as parentWindowID. that is an odd API.
(I know, DOM is odd since window.parent can be the window itself).
So, at least change the name of the property
'parentOrSelfWindowID' and then document what the ID actually is.
Attachment #8614943 - Flags: review?(bugs) → review-
Thinking about this more, I guess I don't really need this. I wanted it since the window ID isn't available in the parent process. However, since writing this patch, I rewrote the code that was depending on it to run in a frame script. So it's not necessary.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.