1171230 - Include parent window ID in nsIWebProgress

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This is a useful feature to have, particularly for e10s. It's needed so we can implement the semantics of Chrome's webNavigation API for extensions.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

These are the platform changes.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: toolkit-patch

Here's the toolkit patch.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I don't quite understand the need of this.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

And what should parentWindowID be in case window->GetParent() returns the window itself?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8614943 [details] [diff] [review]
patch

I have the gut feeling this isn't quite what you mean, especially since
DOMWindowID can be the same as parentWindowID. that is an odd API.
(I know, DOM is odd since window.parent can be the window itself).
So, at least change the name of the property
'parentOrSelfWindowID' and then document what the ID actually is.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Thinking about this more, I guess I don't really need this. I wanted it since the window ID isn't available in the parent process. However, since writing this patch, I rewrote the code that was depending on it to run in a frame script. So it's not necessary.