1171234 - Include triggering node in load info when doing prefetching

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

When we see a <link rel="prefetch">, we don't associate the <link> node with the LoadInfo when we do the prefetch. I'm not sure if there's a reason why we don't, but it would be nice for add-ons. Chrome's webRequest extension API associates these prefetched loads with the frame that included the <link> element, so this change would make us more compatible with Chrome.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8614947 [details] [diff] [review]
patch

Review of attachment 8614947 [details] [diff] [review]:
-----------------------------------------------------------------

::: uriloader/prefetch/nsPrefetchService.cpp
@@ +199,1 @@
>  

Thanks for looking at this. In fact that sounds like a great change to me. I am always happy to accept changes where we can replace the systemPrincipal with some more precise info. The loadingNode and the loadingPrincipal must match however, see [1]. But that's an easy fix:

nsresult rv = NS_NewChannelInternal(getter_AddRefs(mChannel),
                                    mURI,
                                    source,
                                    source->NodePrincipal(),
                                    nullptr, //aTriggeringPrincipal
                                    ...

That should do it.

[1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/LoadInfo.cpp#39

Comment 2

[Boris Zbarsky [:bzbarsky]]

Please fix the indentation to not use tabs?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f7eb3853f3c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f7eb3853f3c