Closed Bug 1171348 Opened 5 years ago Closed 5 years ago

Switch password manager to richer logging via console.jsm

Categories

(Toolkit :: Password Manager, enhancement)

enhancement
Not set
Points:
3

Tracking

()

RESOLVED FIXED
mozilla41
Iteration:
41.2 - Jun 8
Tracking Status
firefox41 --- fixed

People

(Reporter: MattN, Assigned: MattN)

Details

Attachments

(2 files)

For LoginRecipes.jsm I made a helper to log via console.jsm to reduce the boilerplate and provider richer logging and the ability for finer grained logging levels in the future.

Being able to easily log DOM elements or other objects and inspect them speeds up development and debugging. Being able to jump right to the line that did the logging is also very useful too.

While I was touching logging prefixes, I made all modules contain the word "Login" so it's easier to filter for relevant messages.
Bug 1171348 - Switch password manager to richer logging via Console.jsm. r?dolske
Attachment #8615126 - Flags: review?(dolske)
I avoided changing the calls to `log` for now to avoid bitrotting patches/uplifts.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdacdc578050
Thanks for doing this! :-)
Comment on attachment 8615126 [details]
MozReview Request: Bug 1171348 - Switch password manager to richer logging via Console.jsm. r?dolske

https://reviewboard.mozilla.org/r/10179/#review9015

Ship It!
Attachment #8615126 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/afccb8e1c05c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.