1171348 - Switch password manager to richer logging via console.jsm

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[Matthew N. [:MattN]]

Attachment: Screen Shot of richer logging with colours and clickable line numbers/objects

For LoginRecipes.jsm I made a helper to log via console.jsm to reduce the boilerplate and provider richer logging and the ability for finer grained logging levels in the future.

Being able to easily log DOM elements or other objects and inspect them speeds up development and debugging. Being able to jump right to the line that did the logging is also very useful too.

While I was touching logging prefixes, I made all modules contain the word "Login" so it's easier to filter for relevant messages.

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1171348 - Switch password manager to richer logging via Console.jsm. r?dolske

Bug 1171348 - Switch password manager to richer logging via Console.jsm. r?dolske

Comment 2

[Matthew N. [:MattN]]

I avoided changing the calls to `log` for now to avoid bitrotting patches/uplifts.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdacdc578050

Comment 3

[:Paolo Amadini]

Thanks for doing this! :-)

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 8615126 [details]
MozReview Request: Bug 1171348 - Switch password manager to richer logging via Console.jsm. r?dolske

https://reviewboard.mozilla.org/r/10179/#review9015

Ship It!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/afccb8e1c05c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afccb8e1c05c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afccb8e1c05c