1171499 - [GMP] EncodingComplete can happen while GMPVideoEncoderChild is still in use.

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Ethan Hugg [:ehugg]]

Bug 1162358 just landed that fixed this for the Decoder, but it is probable that the same problem exists with the GMPVideoEncoder.  The Encoder is used for WebRTC but not for EME which may be why we have not run into a similar crash.

Comment 1

[Maire Reavy [:mreavy]]

Ethan -- Can you take this bug or should I look for another owner?  Thanks.

Comment 2

[Ethan Hugg [:ehugg]]

Attachment: Defer processing GMP EncodingComplete() calls until intr shmem allocs are finished

Comment 3

[Ethan Hugg [:ehugg]]

Comment on attachment 8617576 [details] [diff] [review]
Defer processing GMP EncodingComplete() calls until intr shmem allocs are finished


This is analogous to the patch in bug 1162358.  I will put it up for review after I do a bit more testing with it.

Comment 4

[Ethan Hugg [:ehugg]]

Comment on attachment 8617576 [details] [diff] [review]
Defer processing GMP EncodingComplete() calls until intr shmem allocs are finished


Sending review to Randell since this is still essentially Chris' patch.

Comment 5

[Ethan Hugg [:ehugg]]

Try run here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dce9adfb692f

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/820c0d23d72c

Comment 7

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/820c0d23d72c