Closed Bug 1171499 Opened 4 years ago Closed 4 years ago

[GMP] EncodingComplete can happen while GMPVideoEncoderChild is still in use.

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed
Blocking Flags:

People

(Reporter: ehugg, Assigned: ehugg)

Details

Attachments

(1 file)

Bug 1162358 just landed that fixed this for the Decoder, but it is probable that the same problem exists with the GMPVideoEncoder.  The Encoder is used for WebRTC but not for EME which may be why we have not run into a similar crash.
Ethan -- Can you take this bug or should I look for another owner?  Thanks.
backlog: --- → webRTC+
Rank: 15
Flags: needinfo?(ethanhugg)
Priority: -- → P1
Assignee: nobody → ethanhugg
Flags: needinfo?(ethanhugg)
Comment on attachment 8617576 [details] [diff] [review]
Defer processing GMP EncodingComplete() calls until intr shmem allocs are finished


This is analogous to the patch in bug 1162358.  I will put it up for review after I do a bit more testing with it.
Comment on attachment 8617576 [details] [diff] [review]
Defer processing GMP EncodingComplete() calls until intr shmem allocs are finished


Sending review to Randell since this is still essentially Chris' patch.
Attachment #8617576 - Flags: review?(rjesup)
Attachment #8617576 - Flags: review?(rjesup) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/820c0d23d72c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.