Closed Bug 1171520 Opened 8 years ago Closed 8 years ago

The "Getting Started" default bookmarks has no favicon; it should use the Firefox favicon.

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: cpeterson, Assigned: axitkhurana, Mentored)

References

Details

(Whiteboard: [good first bug][lang=xul])

Attachments

(1 file, 2 obsolete files)

getting-started-bookmark-default-favicon2.patch
5.33 KB, patch
jaws
: review+
Details | Diff | Splinter Review 
See bug 972138 to see how a similar bug was fixed. The other default favicons had been using the wrong icon.

In bug 972138 comment 1, Marco says "it's just matter of updating https://mxr.mozilla.org/mozilla-central/source/browser/locales/generic/profile/bookmarks.html.in with new ICON data URIs."

@Manan: You fixed bug 972138. Do you have time to fix this favicon bug? :)
Flags: needinfo?(manan.doshi96)
Mentor: manishearth
@Manish: First bug, gave it a shot based on bug 972138. I added r=jaws in the commit message as in the related bug, let me know if that should be someone else.

@Chris: Hope this was OK to work on, wasn't sure if @Manan had started or not.

Thanks!
Attachment #8616459 - Flags: review+
Attachment #8616459 - Flags: feedback+
Attached image ScreenshotWithMozillaFavicon.png (obsolete) — 

        Attachment #8616459 -
        Flags: review?(jaws)

        Attachment #8616459 -
        Flags: review+

        Attachment #8616459 -
        Flags: feedback+

    
    

    
  
Comment on attachment 8616459 [details] [diff] [review]
getting-started-bookmark-default-favicon.patch

Review of attachment 8616459 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for submitting a patch :) The favicon for the Getting Started page is actually the Firefox logo, not the Mozilla "m".

You can use the following data URI for the Firefox icon,
data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAz5JREFUeNpcU0toXFUY/s49596588ikySSmM8rk0UkJEirVTVEjYk1NUdRFFgouXZQI2k2hUCjdiYIuCi4Kuig0DbqQYgU3Yi0iFRuRCBMwaZvMZDTNY95z3/fM8b8jldpzOeeee/i/737n+/+f4ZExf730rkiaZ9NJMx/nmk5HypMqqLr+ZuD4F67N5ZYejmfRsnvhyKsLhSs3zP70SubgYKHSdFENu+gXAprQIGnvBi5ez0m1b6u7M399+PTx+UvtCKtFi2F6195qXK2byir88esy5ksfYND5DhuhRCtUKBNB0Q7w5Z8ee2GgWdjOn250fn5v5j8F5dOHlZD0kWRgAwp3hrKY0S9BJWKIcQ5PShhNG4+1bHx+IocT+RXcrRSDMfFNRvvt3Oyp/icIrRhUl9hoO4kt3F55Bxf3LkLV20jWOohbDjzXxyc/lMH0cRSyCd1xq+dFhu986t7T0CUwIzB8EkW3O5ibhj44ib7NJhiBKRoB/aS4ZWHjbxtjGQYP7nGRTjim1SaQqYiAVAREpHG8vzWJn+6PQ6CF0HPR7nQQczpYeEWHyWMUkwU8MSECGwgJxAWp9xWKNzkuH3oet+JDlIE9Momedh1G4CN0bfhVG9nsS0BQQthJx0V7j3elq7ihqV5ezQTwZmodP9ZGkU/bOPr4Nr53xtDYsaD7Dg4nNqFaH5OCYSSdGhf7daNmuv6wEKqXk/yExKGBHSznFsH6FFpKQ/JAA0ulUejWLt44lkHXsqDaX6C6Nl4Rnq8vK8s/KThDMlJhkI91YOO+iR3XwEelCdTCBLSgijNzd6DLNfhlHfZ6FtWiWBQpq/V2LdSrrNPljBQkoOjuCiPxAMutOIbkPqYSEqeequGZaTLzdhZhS0PlnlB9bvhtr5CuHj3y2Qj8hVQ/kEopxONEEsO/0yATDYXYAdWrE69JEElXq7Hyk0tro+xBU1yZmr4xrIcvptIRCZlJJAYBmRGRkD08aivA7VDvWPqt564Xn41w/AHB1/u7l1/uGxGU8mNcgodUNDIq0JDeLnpzc1uo1Qr76rWbqyf/142PjsXJqdkmN2YDnQ9oGkJNU+t57q7qUv4y9/t64+HYfwQYAN7OczrzUDvGAAAAAElFTkSuQmCC

        Attachment #8616459 -
        Flags: review?(jaws) → review-

    
    

    
  
This might be easier to copy/paste:
> data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAz5JREFUeNpcU0toXFUY/s49596588ikySSmM8rk0UkJEirVTVEjYk1NUdRFFgouXZQI2k2hUCjdiYIuCi4Kuig0DbqQYgU3Yi0iFRuRCBMwaZvMZDTNY95z3/fM8b8jldpzOeeee/i/737n+/+f4ZExf730rkiaZ9NJMx/nmk5HypMqqLr+ZuD4F67N5ZYejmfRsnvhyKsLhSs3zP70SubgYKHSdFENu+gXAprQIGnvBi5ez0m1b6u7M399+PTx+UvtCKtFi2F6195qXK2byir88esy5ksfYND5DhuhRCtUKBNB0Q7w5Z8ee2GgWdjOn250fn5v5j8F5dOHlZD0kWRgAwp3hrKY0S9BJWKIcQ5PShhNG4+1bHx+IocT+RXcrRSDMfFNRvvt3Oyp/icIrRhUl9hoO4kt3F55Bxf3LkLV20jWOohbDjzXxyc/lMH0cRSyCd1xq+dFhu986t7T0CUwIzB8EkW3O5ibhj44ib7NJhiBKRoB/aS4ZWHjbxtjGQYP7nGRTjim1SaQqYiAVAREpHG8vzWJn+6PQ6CF0HPR7nQQczpYeEWHyWMUkwU8MSECGwgJxAWp9xWKNzkuH3oet+JDlIE9Momedh1G4CN0bfhVG9nsS0BQQthJx0V7j3elq7ihqV5ezQTwZmodP9ZGkU/bOPr4Nr53xtDYsaD7Dg4nNqFaH5OCYSSdGhf7daNmuv6wEKqXk/yExKGBHSznFsH6FFpKQ/JAA0ulUejWLt44lkHXsqDaX6C6Nl4Rnq8vK8s/KThDMlJhkI91YOO+iR3XwEelCdTCBLSgijNzd6DLNfhlHfZ6FtWiWBQpq/V2LdSrrNPljBQkoOjuCiPxAMutOIbkPqYSEqeequGZaTLzdhZhS0PlnlB9bvhtr5CuHj3y2Qj8hVQ/kEopxONEEsO/0yATDYXYAdWrE69JEElXq7Hyk0tro+xBU1yZmr4xrIcvptIRCZlJJAYBmRGRkD08aivA7VDvWPqt564Xn41w/AHB1/u7l1/uGxGU8mNcgodUNDIq0JDeLnpzc1uo1Qr76rWbqyf/142PjsXJqdkmN2YDnQ9oGkJNU+t57q7qUv4y9/t64+HYfwQYAN7OczrzUDvGAAAAAElFTkSuQmCC
Flags: needinfo?(manan.doshi96)

    
    

    
  


  
Oops. Updated.

Thanks Jared, Manish.

        Attachment #8616459 -
        Attachment is obsolete: true

        Attachment #8616460 -
        Attachment is obsolete: true

        Attachment #8616495 -
        Flags: review?(jaws)

        Attachment #8616495 -
        Flags: review?(jaws) → review+
Assignee: nobody → axitkhurana
Summary: The "Getting Started" default bookmarks has no favicon; it should use the new mozilla.org M favicon. → The "Getting Started" default bookmarks has no favicon; it should use the Firefox favicon.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/779e05d8125c
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox41:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41

          You need to log in
          before you can comment on or make changes to this bug.