1171562 - [e10s] remove CPOW usage from "test Anchor And Arrow" in test-panel.js

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/2013

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8615435 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/2013

Passing a DOM node to panel.show looks to be deprecated. I don't know if there is a replacement yet but maybe this method can be removed?

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Dave Townsend [:mossop] from comment #2)
> Comment on attachment 8615435 [details] [review]
> Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/2013
> 
> Passing a DOM node to panel.show looks to be deprecated. I don't know if
> there is a replacement yet but maybe this method can be removed?

Maybe, I think we have button tests which use this, so it might be more difficult to remove.

This bit is safe to remove for now I think.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1121a2eb45b7c77d7460a2da02ba04c6ddd28a41
Bug 1171562 - [e10s] remove CPOW usage from "test Anchor And Arrow" in test-panel.js

https://github.com/mozilla/addon-sdk/commit/455202325da596e9b5d7802115734a36eff1457c
Merge pull request #2013 from erikvold/1171562

Bug 1171562 - [e10s] remove CPOW usage from "test Anchor And Arrow" in test-panel.js r=mossop

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b167559baae0bb959cda9963e2252f9faa638a16
Bug 1171562 - [e10s] remove CPOW usage from "test Anchor And Arrow" in test-panel.js r=mossop

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hey Mossop - this is another one of these SDK bugs that looks like it's been patched, but is still open.

Looking at the patch, and then looking at m-c, it looks like we're just waiting on an SDK uplift, correct? Do you know offhand when such an uplift is likely to occur?

Comment 7

[Dave Townsend [:mossop]]

No-one is tasked with doing uplifts at the moment. I'll try to do one this week.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

This is test only.

Comment 9

[Andy McKay]

Since this is for e10s this would be nice to uplift, would anyone have chance to move this to mozilla-central?

Comment 10

[:shell escalante]

any interest in landing this one?  or has it become irrelevant.  sounds like the SDK tests got fixed but not included.

Comment 11

[Dave Townsend [:mossop]]

Looks like it landed already