Closed
Bug 1171564
Opened 10 years ago
Closed 10 years ago
[Raptor] Memory is captured incorrectly for lower process IDs
Categories
(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S14 (12june)
People
(Reporter: Eli, Assigned: Eli)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
More bad logic in the memory logger; Raptor fails to capture memory metrics correctly if the process ID is less than 5 digits, as we only are looking ahead 1 character to start the next b2g-info entry.
|
Assignee | |
Comment 1•10 years ago
|
||
Also add some guarding logic for the performance parser.
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8615446 -
Flags: review?(rwood)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8615446 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30418
LGTM and tested by running the launch test several times on the flame, and verified the memory entry values were never null/zero.
Attachment #8615446 -
Flags: review?(rwood) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•