Closed Bug 1171564 Opened 9 years ago Closed 9 years ago

[Raptor] Memory is captured incorrectly for lower process IDs

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::PerformanceTest
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S14 (12june)

People

(Reporter: Eli, Assigned: Eli)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30418
46 bytes, text/x-github-pull-request
rwood
: review+
Details | Review 
More bad logic in the memory logger; Raptor fails to capture memory metrics correctly if the process ID is less than 5 digits, as we only are looking ahead 1 character to start the next b2g-info entry.
Also add some guarding logic for the performance parser.
Comment on attachment 8615446 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30418

LGTM and tested by running the launch test several times on the flame, and verified the memory entry values were never null/zero.
Attachment #8615446 - Flags: review?(rwood) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/4a0287a62e89a3abbd77f54e1a0fcc95097a80d0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: