1171583 - nsSimpleURI.cpp emits "WARNING: NS_ENSURE_TRUE(mMutable) failed" over 14,000 times in linux debug test logs

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Eric Rahm [:erahm]]

> WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/m-cen-l64-d-000000000000000000/build/src/netwerk/base/nsSimpleURI.cpp, line 264

AFAICT |nsSimpleURI::SetUserPass| [1] is not implemented in any of it's subclasses, we should probably just remove the warning.

[1] https://hg.mozilla.org/mozilla-central/annotate/98820360ab66/netwerk/base/nsSimpleURI.cpp#l262

Comment 1

[Eric Rahm [:erahm]]

Example stack from running |./mach mochitest browser/components/sessionstore/test/browser_522545.js|.

#0  nsSimpleURI::SetUserPass (this=0x7fffc2dc3a60, userPass=...) at /home/erahm/dev/mozilla-central/netwerk/base/nsSimpleURI.cpp:265
#1  0x00007ffff05de3f1 in NS_InvokeByIndex (that=<optimized out>, methodIndex=<optimized out>, paramCount=<optimized out>, params=<optimized out>)
    at /home/erahm/dev/mozilla-central/xpcom/reflect/xptcall/md/unix/xptcinvoke_x86_64_unix.cpp:176
#2  0x00007ffff0c4f2b0 in Invoke (this=0x7fffffff3bc8) at /home/erahm/dev/mozilla-central/js/xpconnect/src/XPCWrappedNative.cpp:2080
#3  CallMethodHelper::Call (this=this@entry=0x7fffffff3bc8) at /home/erahm/dev/mozilla-central/js/xpconnect/src/XPCWrappedNative.cpp:1417
#4  0x00007ffff0c3b992 in XPCWrappedNative::CallMethod (ccx=..., mode=<optimized out>)
    at /home/erahm/dev/mozilla-central/js/xpconnect/src/XPCWrappedNative.cpp:1384
#5  0x00007ffff0c43d91 in SetAttribute (ccx=...) at /home/erahm/dev/mozilla-central/js/xpconnect/src/xpcprivate.h:2189
#6  XPC_WN_GetterSetter (cx=0x7fffd613dca0, argc=<optimized out>, vp=<optimized out>)
    at /home/erahm/dev/mozilla-central/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1172
#7  0x00007ffff2dbcaa2 in js::CallJSNative (cx=0x7fffd613dca0, native=0x7ffff0c43b44 <XPC_WN_GetterSetter(JSContext*, unsigned int, JS::Value*)>, args=...)
    at /home/erahm/dev/mozilla-central/js/src/jscntxtinlines.h:235
#8  0x00007ffff2dabdba in js::Invoke (cx=cx@entry=0x7fffd613dca0, args=..., construct=construct@entry=js::NO_CONSTRUCT)
    at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:703
#9  0x00007ffff2dadb98 in js::Invoke (cx=cx@entry=0x7fffd613dca0, thisv=..., fval=..., argc=argc@entry=1, argv=argv@entry=0x7fffffff4970, rval=..., 
    rval@entry=...) at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:760
#10 0x00007ffff2db4d91 in js::InvokeSetter (cx=cx@entry=0x7fffd613dca0, thisv=..., fval=..., v=v@entry=...)
    at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:845
#11 0x00007ffff2e23c29 in SetExistingProperty (result=..., shape=..., pobj=..., receiver=..., v=..., id=..., obj=..., cx=0x7fffd613dca0)
    at /home/erahm/dev/mozilla-central/js/src/vm/NativeObject.cpp:2200
#12 js::NativeSetProperty (cx=cx@entry=0x7fffd613dca0, obj=..., id=..., value=..., value@entry=..., receiver=..., qualified=qualified@entry=js::Qualified, 
    result=...) at /home/erahm/dev/mozilla-central/js/src/vm/NativeObject.cpp:2234
#13 0x00007ffff2da6902 in SetProperty (result=..., receiver=..., v=..., id=..., obj=..., cx=0x7fffd613dca0)
    at /home/erahm/dev/mozilla-central/js/src/vm/NativeObject.h:1437
#14 SetPropertyOperation (rval=..., id=..., lval=..., op=JSOP_SETPROP, cx=0x7fffd613dca0) at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:315
#15 Interpret (cx=cx@entry=0x7fffd613dca0, state=...) at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:2761
#16 0x00007ffff2dab7c3 in js::RunScript (cx=cx@entry=0x7fffd613dca0, state=...) at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:652
#17 0x00007ffff2dabf4b in js::Invoke (cx=cx@entry=0x7fffd613dca0, args=..., construct=construct@entry=js::NO_CONSTRUCT)
    at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:723
#18 0x00007ffff3259e6d in js::fun_apply (cx=0x7fffd613dca0, argc=<optimized out>, vp=0x7fffffff6b78) at /home/erahm/dev/mozilla-central/js/src/jsfun.cpp:1288
#19 0x00007ffff2dbcaa2 in js::CallJSNative (cx=0x7fffd613dca0, native=0x7ffff3259a80 <js::fun_apply(JSContext*, unsigned int, JS::Value*)>, args=...)
    at /home/erahm/dev/mozilla-central/js/src/jscntxtinlines.h:235
#20 0x00007ffff2dabdba in js::Invoke (cx=cx@entry=0x7fffd613dca0, args=..., construct=construct@entry=js::NO_CONSTRUCT)
    at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:703
#21 0x00007ffff2dadb98 in js::Invoke (cx=cx@entry=0x7fffd613dca0, thisv=..., fval=..., argc=argc@entry=2, argv=argv@entry=0x7fffffff7008, rval=..., 
    rval@entry=...) at /home/erahm/dev/mozilla-central/js/src/vm/Interpreter.cpp:760
#22 0x00007ffff2fda18a in js::jit::DoCallFallback (cx=0x7fffd613dca0, frame=0x7fffffff7078, stub_=<optimized out>, argc=<optimized out>, vp=0x7fffffff6ff8, 
    res=...) at /home/erahm/dev/mozilla-central/js/src/jit/BaselineIC.cpp:9790
(gdb) p this
$1 = (nsNestedAboutURI * const) 0x7fffc2dc3a60

Doing |p this| for the rest indicated they were all nsNestedAboutURI's.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Remove mutable warning from |nsSimpleURI::SetUserPass|

This is the simplest fix unless we decided that this is really pointing to an actual error.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Example stack from running

Well, ok, but what's interesting there is clearly the JS stack..

But yeah, if we plan to throw anyway I'm not sure warning adds much.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8621254 [details] [diff] [review]
Remove mutable warning from |nsSimpleURI::SetUserPass|

r=me

Comment 5

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e346f3cdfc61

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e346f3cdfc61