1171626 - Tapping item in Reading List takes you to article or causes crash

Status: RESOLVED FIXED

(Firefox for iOS :: Reading List, defect)

Description

[Robin Andersen [:tecgirl]]

Tapping the blue indication dot in Reading List should toggle the Read/Unread state.

Instead, it will either navigate to the article or cause a crash.

Comment 1

[Richard Newman [:rnewman]]

ReadabilityBrowserHelper.init?, browser.webView! -- but .webView is nil.

This is running on the main thread, triggered via ReadabilityOperation.main:50.

Should be pretty easy to solve via inspection.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The blue dot is just an indicator. It is not a button.

To toggle the read/unread state, swipe the cell to the right.

This is a major regression and can be summarized as 'Opening an item from the reading list causes a crash'

This must be because of some other unrelated changes. I'll investigate.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is because of the lazy loading of the WKWebview that was introduced recently.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/669

This patch fixes a regression that was introduced after the lazy loading of the `WKWebView` was implemented. The `ReadabiltyOperation` requires the `Browser.webView` to be present so this patch simply calls `createWebview()` to ensure that.

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8629193 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/669

Looks good to me!

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Robin, this crash is fixed. But see comment #2 about the blue dot not being a button. Please file a bug if that needs to change.