Closed Bug 1171721 Opened 8 years ago Closed 7 years ago

UUID commit hook is unaware of more than one interface in the same file

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mccr8, Assigned: poiru)

References

Details

Attachments

(1 file)

hghooks: Tighten regex for IDL attribute list matching
2.90 KB, patch
gps
: review+
Details | Diff | Splinter Review 
In this commit, the UUID commit hook said I had to change the UUID of nsICycleCollectorHandler, even though the interface doesn't change:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a872a9e3d116

There was another interface, nsICycleCollectorLogSink, that it was okay with me not changing.
I just hit this as well.  I'm not sure why the hook was implemented this way, but this is very annoying.
Blocks: 1128518
Summary: UUID commit hook said I had to change a UUID unnecessarily → UUID commit hook is unaware of more than one interface in the same file
(In reply to Ehsan Akhgari (don't ask for review please) from comment #1)
> I just hit this as well.  I'm not sure why the hook was implemented this
> way, but this is very annoying.

Sorry, it was unintentional. I'll take a look.
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Any updates?  This doesn't happen every day but it's really annoying when it does happen.  :(
(In reply to Ehsan Akhgari (don't ask for review please) [Away Nov 3-19] from comment #3)
> Any updates?

This fixes the issue. I apologize for the delay!
Attachment #8681658 - Flags: review?(gps)
Comment on attachment 8681658 [details] [diff] [review]
hghooks: Tighten regex for IDL attribute list matching

Review of attachment 8681658 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land this for you.
Attachment #8681658 - Flags: review?(gps) → review+
This is deploying now.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.