1171721 - UUID commit hook is unaware of more than one interface in the same file

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Andrew McCreight [:mccr8]]

In this commit, the UUID commit hook said I had to change the UUID of nsICycleCollectorHandler, even though the interface doesn't change:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a872a9e3d116

There was another interface, nsICycleCollectorLogSink, that it was okay with me not changing.

Comment 1

[(no longer active)]

I just hit this as well.  I'm not sure why the hook was implemented this way, but this is very annoying.

Comment 2

[Biru [:poiru]]

(In reply to Ehsan Akhgari (don't ask for review please) from comment #1)
> I just hit this as well.  I'm not sure why the hook was implemented this
> way, but this is very annoying.

Sorry, it was unintentional. I'll take a look.

Comment 3

[(no longer active)]

Any updates?  This doesn't happen every day but it's really annoying when it does happen.  :(

Comment 4

[Biru [:poiru]]

Attachment: hghooks: Tighten regex for IDL attribute list matching

(In reply to Ehsan Akhgari (don't ask for review please) [Away Nov 3-19] from comment #3)
> Any updates?

This fixes the issue. I apologize for the delay!

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8681658 [details] [diff] [review]
hghooks: Tighten regex for IDL attribute list matching

Review of attachment 8681658 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land this for you.

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/63366c8be634f85db2709bafbec70ea32a604e51
hghooks: Tighten regex for IDL attribute list matching (bug 1171721); r=gps

Comment 8

[Gregory Szorc [:gps]]

This is deploying now.