1171841 - [TC] Fix ubuntu-build image to work with clang (for asan builds).

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Morgan Phillips [:mrrrgn]]

Right now the tooltool clang that lives in /home/worker/workspace/src/clang is broken because it can't find the appropriate libraries. We also need to install valgrind.

Comment 1

[Morgan Phillips [:mrrrgn]]

Attachment: Path 1 - Add valgrind to ubuntu builder

Comment 2

[Morgan Phillips [:mrrrgn]]

Attachment: Patch 2 - Fix include paths for clang

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Should we have mozbootstrap installing valgrind instead?  If no, then I think this looks fine.

Comment 4

[Morgan Phillips [:mrrrgn]]

Attachment: Patch 3 - Version bumps

Comment 5

[Morgan Phillips [:mrrrgn]]

(In reply to Dustin J. Mitchell [:dustin] from comment #3)
> Should we have mozbootstrap installing valgrind instead?  If no, then I
> think this looks fine.

I hadn't thought so. The other libraries are really necessary to do a ff build; but valgrind is optional. I don't want to totally hijack mozboot by loading it with libraries that devs don't need. I may be mistaken about the utility of having valgrind for devs though.

Comment 6

[Morgan Phillips [:mrrrgn]]

(In reply to Dustin J. Mitchell [:dustin] from comment #3)
> Should we have mozbootstrap installing valgrind instead?  If no, then I
> think this looks fine.

I've got to think of this more I think. It's a tough call.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

I'll mark this r+ if you decide that this is the right course.

I think the key questions are:
* how important is the specific version of valgrind (we're installing "latest" now)?
* how frequently will that version need to change (and thus how important is it that it's easy)?
* how important is it that devs using mozbootstrap get exactly the same version as automation?

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/506253ae8d71
https://hg.mozilla.org/integration/mozilla-inbound/rev/014de6ca0e6a
https://hg.mozilla.org/integration/mozilla-inbound/rev/0dca3f73814c

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/506253ae8d71
https://hg.mozilla.org/mozilla-central/rev/014de6ca0e6a
https://hg.mozilla.org/mozilla-central/rev/0dca3f73814c