1171848 - [RTL][Contacts]The scrollbar is not mirrored in the comment section at edit contact view.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Sue]

Attachment: scrollbar in comment of contacts.png

[1.Description]:
[RTL][Flame 2.2&3.0][Nexus5 2.2&3.0][Contacts]The scrollbar is right-aligned in the comments section at edit contact view.
See attachment:scrollbar in comment of contacts.png

[2.Testing Steps]: 
1. Set system language as Arabic.
2. Launch Contacts.
3. Tap "+" button to Add a contacts.
4. Enter enough text in the comments box to make it scrollable.
5. Scroll the box.

[3.Expected Result]: 
5. The scrollbar should be left-aligned.

[4.Actual Result]: 
5. The scrollbar is right-aligned.

[5.Reproduction build]: 
Device: Flame 2.2 (affected)
Build ID               20150604162503
Gaia Revision          8fc797527a3eca7665bc1d1828848f2fb77ca99f
Gaia Date              2015-06-04 07:46:11
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f2157a04d75b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150604.195708
Firmware Date          Thu Jun  4 19:57:20 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (affected)
Build ID               20150604160205
Gaia Revision          e0fbadeb78a96137f071d9be7a47ef9fe882d17f
Gaia Date              2015-06-04 07:44:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5b4c240e1a36
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150604.192904
Firmware Date          Thu Jun  4 19:29:16 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (affected)
Build ID               20150604162503
Gaia Revision          8fc797527a3eca7665bc1d1828848f2fb77ca99f
Gaia Date              2015-06-04 07:46:11
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f2157a04d75b
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150604.195634
Firmware Date          Thu Jun  4 19:56:49 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (affected)
Build ID               20150604160205
Gaia Revision          e0fbadeb78a96137f071d9be7a47ef9fe882d17f
Gaia Date              2015-06-04 07:44:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5b4c240e1a36
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150604.192430
Firmware Date          Thu Jun  4 19:24:48 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[William Hsu [:whsu]]

Bad user experience, but it doesn't much user impact.
Mark it as P2 case.

Comment 2

[Lancy(Leave from Mozilla)]

Attachment: AriesKK_v2.5.png

This issue can be reproduced on latest AriesKK v2.5 build by the same STR in comment 0.
Actual Result: 
The scrollbar is right-aligned in the comments section at edit contact view.

See attachment:AriesKK_v2.5.png.
Reproducing rate:10/10

Device: Aries KK v2.5 build
Build ID               20150810003528
Gaia Revision          09dea2d5ff21cdb56da35fe4aa5bf4c90cf1da7f
Gaia Date              2015-08-09 17:11:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0e269a1f1beb
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150810.000017
Firmware Date          Mon Aug 10 00:00:24 UTC 2015
Bootloader             s1

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1171848-contact_caret_misplaced > mozilla-b2g:master

Comment 4

[Augustin Trancart [:autra]]

Comment on attachment 8681182 [details] [review]
[gaia] Phoxygen:bug1171848-contact_caret_misplaced > mozilla-b2g:master

Hi Borja,

Please r? thanks!

Comment 5

[Augustin Trancart [:autra]]

Comment on attachment 8681182 [details] [review]
[gaia] Phoxygen:bug1171848-contact_caret_misplaced > mozilla-b2g:master

Francisco, I'm forwarding that to you (Borja seems not to be around). Can you r? that for me? Thanks!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8681182 [details] [review]
[gaia] Phoxygen:bug1171848-contact_caret_misplaced > mozilla-b2g:master

Tested on the phone and working perfectly.

Thanks for the contribution!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/607b9c5db7fdbbafc16a572e7c319baa266a3372

in NGA branch:

1dac2c6

Comment 8

[Augustin Trancart [:autra]]

Comment on attachment 8681182 [details] [review]
[gaia] Phoxygen:bug1171848-contact_caret_misplaced > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: bad rtl support
[Testing completed]: on flame master
[Risk to taking this patch] (and alternatives if risky): low risk. Simple change, well tested.
[String changes made]: none

Comment 9

[Mahendra Potharaju [:mahe]]

Comment on attachment 8681182 [details] [review]
[gaia] Phoxygen:bug1171848-contact_caret_misplaced > mozilla-b2g:master

Approved for 2.5

Thanks

Comment 10

[zouyi(Leave from Mozilla)]

This bug has been verified as pass on latest build of Flame KK v2.6 512mb(master) and Aries KK v2.6(master) by the STR in Comment 0.

Actual results: The scrollbar of the comment box is left-aligned.

See attachment: verified_Aries_v2.6(master).png

Reproduce rate: 0/10

Device: Flame KK v2.6master(Pass)
Build ID               20151115150212
Gaia Revision          e8c15ae4e5324a210000ee0a869a962aa542009f
Gaia Date              2015-11-13 00:10:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7cd2d806bd069c0260ff73f023ac85f892b863bf
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151115.184416
Firmware Date          Sun Nov 15 18:44:31 EST 2015
Firmware Version       V18D V4
Bootloader             L1TC000118D0

Dvvice: Aries KK v2.6master(Pass):
Build ID               20151112120735
Gaia Revision          27bc9412ca607648bc398b25bb1ae25653b2b278
Gaia Date              2015-11-12 02:27:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.112635
Firmware Date          Thu Nov 12 11:26:43 UTC 2015
Bootloader             s1

Comment 11

[zouyi(Leave from Mozilla)]

Attachment: verified_Aries_v2.6(master).png

Comment 12

[Carsten Book [:Tomcat]]

2.5 checkin - https://github.com/mozilla-b2g/gaia/commit/bf73da3e1c1c2cfd3377346de77fdbe4d6b9b75d

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest user build of Flame KK v2.5 512mb and Aries KK v2.5 by the STR in Comment 0.

Actual results: The scrollbar of the comment box is left-aligned.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 512mb user build (Pass)
Build ID               20151117132020
Gaia Revision          28d63cf3bdc4417f7ad8cab2230f096bf9f6d3b5
Gaia Date              2015-11-17 07:35:12
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8f193d35090cdceac7a7de513244ef4cd976133f
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151117.123256
Firmware Date          Tue Nov 17 12:33:05 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 user build (Pass)
Build ID               20151117132925
Gaia Revision          28d63cf3bdc4417f7ad8cab2230f096bf9f6d3b5
Gaia Date              2015-11-17 07:35:12
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8f193d35090cdceac7a7de513244ef4cd976133f
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151117.123839
Firmware Date          Tue Nov 17 12:38:47 UTC 2015
Bootloader             s1

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.png