Closed Bug 1171858 Opened 6 years ago Closed 6 years ago

ContentEventHandler::OnQueryCaretRect() should honor writing mode when it guesses caret rect from frame's point

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 2 open bugs)

Details

(Keywords: inputmethod)

Attachments

(1 file)

Attached patch PatchSplinter Review
First, when caret isn't show in the specified offset, caret rect is guessed from text rect at the offset. However, it doesn't check writing mode.

Additionally, the caret height (or width in vertical writing mode) is computed by frame's height because at implementing the method, the frame is assumed that it's always a textframe. But not so. So, we should refer the font height for that. This is same as nsCaret.
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsCaret.cpp?rev=d9e2afd7c146&mark=330-339#309
Attachment #8616030 - Flags: review?(bugs)
Attachment #8616030 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/4ffb0322905d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.