1171862 - [FLAME-L] Screen flashes when tapping on it

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Eric Chang [:ericcc] [:echang]]

### STR
1. Open Settings -> Download -> tap on white space
2. Also happening on other apps.

### Actual
https://youtu.be/H9vVGLPg978
Screen flashes 


### Version
Local build

Build ID               20150601113003
Gaia Revision          59b859d1cdce2619d4fbf84558b3db376aded83b
Gaia Date              2015-06-01 03:11:33
Gecko Revision         n/a
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      5.0
Firmware(Incremental)  eng.viralwang.20150601.111147
Firmware Date          Mon Jun  1 11:13:04 CST 2015
Bootloader             L1TC00011L60

Comment 1

[Eric Chang [:ericcc] [:echang]]

1. Also happening in Gallery apps

Comment 2

[Ken Chang[:kenkai]]

Jerry, can you please check this problem?

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

After turning off the hardware composer, I don't see the the problem as comment 0. I need to check the hwc function at our new flame-l environment.

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Ken,
The hwc on flame-l seems broken. I test with a simplified app which only have 1 color-layer and the screen is flickering. Since it only use color-fill feature, I don't think we have fence sync problem. Do we have hwc driver support for flame-l?

Comment 5

[Michael Wu [:mwu]]

FWIW, flame-l is using an Android base version (5.0) that's different from the version that's being supporting in CAF for Lollipop (5.1). Color fill is a HWC feature that only Gecko uses, so it's not surprising that it would have issues on an unsupported base.

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Michael,
We query the color-fill feature and get the supported value here[1], but it seems still have problem for this function.
https://hg.mozilla.org/mozilla-central/annotate/e7e69cc8c07b/widget/gonk/HwcComposer2D.cpp#l122

Comment 7

[Michael Wu [:mwu]]

If it helps, we can probably disable colorfill since we have a fork of the hwc hal for the flame-l port - https://github.com/mozilla-b2g/hardware_qcom_display/tree/foxfone-one-lollipop .

Alternately, you might be able to find a fix for this issue in CAF. If you do, that fix can be cherry-picked over.

Comment 8

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Finally, I know what's going on here!
We have a mismatch HWC_BLIT define value between gecko and hal.

Just like https://bugzilla.mozilla.org/show_bug.cgi?id=1127585#c12, I would like to use the higher value for HWC_BLIT. So I will create a pull request to https://github.com/mozilla-b2g/hardware_qcom_display/commits/foxfone-one-lollipop later.

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Fix the mismatched HWC_BLIT value for flame-l device

Comment 10

[Michael Wu [:mwu]]

Comment on attachment 8630946 [details] [review]
Fix the mismatched HWC_BLIT value for flame-l device

Perfect. Good find.

Comment 11

[Jerry Shih[:jerry] (UTC+8) (inactive)]

I am not sure who can handle this pull request.

Comment 12

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/platform_hardware_libhardware/commit/49a8bca97c6aa07eb7af5f2e37b18202d8d9d739