1171894 - Reader View icon is shown for several apple.com trailers

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Reproducible on: Firefox 38.0.5, Firefox 39 Beta 3, Firefox 40.0a2, Firefox 41.0a1

STR
1.Launch Firefox with clean profile
2.Navigate to http://trailers.apple.com/trailers/magnolia/nowitzkitheperfectshot/
3.Play the video
4.Click on “Reader view” button from location bar

ER
Reader view button is not displayed while the videos are played.

AR
“Failed to load article from page” message is displayed in reader view mode and the following error is thrown in browser console: ”Error in ReaderWorker: TypeError: this._doc.documentElement is undefined ReaderMode.jsm:357:0”


Additional notes:
 - This issue is reproducible on Firefox 40.0a2 (2015-06-04), Firefox 41.0a1 (2015-06-04), Firefox 39 Beta 3 ( 20150604162752), Firefox 38.0.5 (20150525141253) under Mac OS X 10.8.5
 - This issue also reproduces for the following trailers:
http://trailers.apple.com/trailers/independent/theaputrilogypatherpanchaliaparajitoapursansar/
http://trailers.apple.com/trailers/magnolia/apigeonsatonabranch/
http://trailers.apple.com/trailers/wb/pointbreak/
http://trailers.apple.com/trailers/independent/cartelland/
http://trailers.apple.com/trailers/independent/freedom/

Comment 1

[Vasilica Tamas, QA [:vtamas]]

Gijs, could you please have a look at this? I'm aware that it's a bit of an edge case, but I'm mostly concerned about the error thrown in the Browser Console.

Comment 2

[:Gijs (he/him)]

Attachment: JSDOMParser fails on this

It's because JSDOMParser fails to produce a DOM out of this HTML. I haven't yet investigated why. Errors:

JSDOMParser error: expected '</object>'
JSDOMParser error: expected '</div>'
JSDOMParser error: expected '</div>'
JSDOMParser error: expected '</div>'
JSDOMParser error: expected '</div>'
JSDOMParser error: expected '</div>'
JSDOMParser error: expected '</div>'
JSDOMParser error: expected '</div>'
JSDOMParser error: expected '</body>'
JSDOMParser error: expected '</html>'

So it looks like the object end tag is missing.

Comment 3

[:Gijs (he/him)]

It's failing because the <embed> tag has a closing tag, which goes against the HTML spec, and because JSDOMParser is pretty inflexible in this respect.

I don't think this is worth fixing unless there are very many pages with this issue.

Comment 4

[:Gijs (he/him)]

WFM, I no longer see the reader mode button, and I think github https://github.com/mozilla/readability/pull/252 fixed the <embed> issue anyway.