about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager

RESOLVED FIXED in Firefox 41

Status

defect
RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: ferjm, Assigned: jaoo)

Tracking

unspecified
FxOS-S1 (26Jun)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed, b2g-master fixed)

Details

Attachments

(2 attachments, 3 obsolete attachments)

Update service workers via about:serviceworkers won't work without this.

This is a follow up of bug 1162088.
Depends on: 1162088
Whiteboard: [s4]
Target Milestone: --- → NGA S3 (26Jun)
Summary: about:serviceworkers in b2g should use the correct principal when calling ServiceWorkerManager → about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager
Assignee: nobody → jaoo
Whiteboard: [s4] → [s3]
Target Milestone: NGA S3 (26Jun) → NGA S2 (12Jun)
Whiteboard: [s3] → [s4]
Target Milestone: NGA S2 (12Jun) → NGA S3 (26Jun)
Whiteboard: [s4] → [s3]
Target Milestone: NGA S3 (26Jun) → NGA S2 (12Jun)
Status: NEW → ASSIGNED
Bug 1155153 is about to land. What makes sense is to work in this bug on top of the patches from bug 1155153. So lets block here on bug 1155153.
Depends on: 1155153
Bug 1155153 - about:serviceworkers should work in e10s mode, r=nsm, r=bholley
Bug 1155153 - [e10s] about:serviceworkers should work in e10s mode. Update B2G implementation. r=baku
Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=fabrice
Depends on: 1171917
Whiteboard: [s3]
Target Milestone: NGA S2 (12Jun) → NGA S3 (26Jun)
Comment on attachment 8617312 [details]
MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice

Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice
Attachment #8617312 - Attachment description: MozReview Request: Enable service workers on b2g → MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice
Attachment #8617312 - Flags: review?(fabrice)
Attachment #8617312 - Flags: review?(amarchesini)
Attachment #8617313 - Attachment is obsolete: true
Attachment #8617314 - Attachment is obsolete: true
Attachment #8617315 - Attachment is obsolete: true
Comment on attachment 8617355 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/30503

Arthur, would you mind to review this please? Thanks!
Attachment #8617355 - Flags: review?(arthur.chen)
Comment on attachment 8617312 [details]
MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice

https://reviewboard.mozilla.org/r/10611/#review10023

Looks good to me.
Attachment #8617312 - Flags: review?(fabrice)
Comment on attachment 8617312 [details]
MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice

https://reviewboard.mozilla.org/r/10611/#review10093

Ship It!
Attachment #8617312 - Flags: review?(amarchesini) → review+

Updated

4 years ago
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
Comment on attachment 8617355 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/30503

r=me, thanks!
Attachment #8617355 - Flags: review?(arthur.chen) → review+
No longer depends on: 1171917
Blocks: 1171917
Hit the following assertion failure when updating the SW via about:sw in b2g. IIRC :baku said this will be fixed by bug 1169044 so lets set the dependency here. Andrea, am I right? Thanks!

Assertion failure: data, at /Volumes/firefoxos/dev/mozilla-central/xpcom/base/nsCycleCollector.cpp:3973
#01: mozilla::OriginAttributes::PopulateFromSuffix(nsACString_internal const&) (nsRefPtr.h:99, in XUL)
Depends on: 1169044
Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini) → needinfo?(nsm.nikhil)
https://hg.mozilla.org/mozilla-central/rev/56b26cd91e76
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
checkin-needed for the gaia bits here. Thanks!
Keywords: checkin-needed
No longer blocks: 1168339
Hi,

Just adding that the update process in about:sw in b2g has been just tested in master and it works as expected. So it seems the crash raised in comment 12 has been fixed by Bug 1169044. Thanks!

Environmental variables:
Flame device
Build Id: 20150629151042
Gecko:13c42a5
Gaia: 3722c4d
Platform version: 41.0a1
Flags: needinfo?(nsm.nikhil)
Blocks: 1179161
You need to log in before you can comment on or make changes to this bug.