1172009 - "Enter Reader View" loads an empty, errorless page on file:///

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Pomax]

I have a single file, XHR-less webpage (online at http://pomax.github.io/bezierjs) which I dev on by simply loading it up in the browser because it doesn't rely on anything other than plain-loaded resources. When I do so, firefox adds the "enter reader view" icon to the URL bar, but clicking it makes Firefox load up a blank page, with a blank URL, and a blank console showing no errors or warnings about the fact that reader view doesn't actually work on file:///

One quick solution is to simply not even show the "enter reader view" icon for file:/// URLs, as being able to click it is actually a worse UX than not even getting it in the first place, or it could perhaps be shown with a cross through it in the same way we mark bad SSL certs, to show that "normally, you would now be able to enter reader mode, but you're on file:/// so you can't" and then if people click it show an infobox with that notice, instead of entering reader mode.

Comment 1

[:Margaret Leibovic]

We already a have a check for file URIs here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/ReaderMode.jsm#292

So something must be going wrong if we're showing the reader button in the URL bar.

Gijs, any ideas? Could we be failing to properly update the reader button?

Comment 2

[:Gijs (he/him)]

(In reply to :Margaret Leibovic from comment #1)
> We already a have a check for file URIs here:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/
> ReaderMode.jsm#292
> 
> So something must be going wrong if we're showing the reader button in the
> URL bar.
> 
> Gijs, any ideas? Could we be failing to properly update the reader button?

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/ReaderMode.jsm#292

  _shouldCheckUri: function (uri) {
    if (!(uri.schemeIs("http") || uri.schemeIs("https") || uri.schemeIs("file"))) {

Comment 3

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1172009 - don't show reader mode button for file:///, r?margaret

Bug 1172009 - don't show reader mode button for file:///, r?margaret

Comment 4

[:Margaret Leibovic]

(In reply to :Gijs Kruitbosch from comment #2)
> (In reply to :Margaret Leibovic from comment #1)
> > We already a have a check for file URIs here:
> > http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/
> > ReaderMode.jsm#292
> > 
> > So something must be going wrong if we're showing the reader button in the
> > URL bar.
> > 
> > Gijs, any ideas? Could we be failing to properly update the reader button?
> 
> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/
> ReaderMode.jsm#292
> 
>   _shouldCheckUri: function (uri) {
>     if (!(uri.schemeIs("http") || uri.schemeIs("https") ||
> uri.schemeIs("file"))) {

Doh, I read that as the opposite of what it actually does :)

Comment 5

[:Margaret Leibovic]

Comment on attachment 8617295 [details]
MozReview Request: Bug 1172009 - don't show reader mode button for file:///, r?margaret

https://reviewboard.mozilla.org/r/10603/#review9289

Ship It!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/09369dc533d3

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09369dc533d3