Closed Bug 1172015 Opened 9 years ago Closed 9 years ago

Build overrides from local ua-update.json

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(p11+, fennec42+)

Status:
RESOLVED DUPLICATE of bug 1178760
Tracking Flags:
Tracking Status
p11 + ---
fennec 42+ ---

People

(Reporter: miketaylr, Unassigned)

References

Details

Snorp noticed this yesterday on IRC, UA overrides in the local ua-update.json aren't applied.

The reason is if general.useragent.updates.enabled is set to false (as it currently is in Fennec until Bug 1163759 is resolved), UserAgentOverrides#buildOverrides early-returns.

<https://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/UserAgentOverrides.jsm?from=UserAgentOverrides.jsm&case=true#152>

That's sort of surprising, I think we should read in the overrides from the local file (only when updates.enabled is false? the first time before fetching an update?)
(this code lives in netwerk/protocol/http/ so maybe this is the wrong place to file this bug?)
tracking-fennec: --- → ?
tracking-fennec: ? → 41+
tracking-p11: --- → +
I think we should not track 41 because a) it's not done >_> and b) something isn't working with the update mechanism. I would suggest we make use of the dynamic overrides in 42+. 

I'd be happy to work on this, seems like a good Q3 goal ("sort out the override mess").
tracking-fennec: 41+ → ?
See Also: → 1178760
tracking-fennec: ? → 42+
See Also: → 1162099
The fix for Bug 1178760 will solve this, so let's dupe against that.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.