Closed Bug 1172100 Opened 9 years ago Closed 9 years ago

remove enable_unittests option from autophone.ini

Categories

(Testing Graveyard :: Autophone, defect)

Product:
Testing Graveyard
Component:
Autophone
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox41 --- affected

People

(Reporter: jmaher, Assigned: bc)

References

Details

Attachments

(1 file)

bug-1172100-remove-enable-unittests.patch
2.42 KB, patch
gbrown
: review+
jmaher
: feedback+
Details | Diff | Splinter Review 
simple fix for autophone, but it is confusing when autophone.ini has a commented out setting for enable_unittests when it should be in the .py file now.
Blocks: 1172984
updated to match current options.
Attachment #8617430 - Flags: review?(gbrown)
Attachment #8617430 - Flags: feedback?(jmaher)
Assignee: nobody → bob
Status: NEW → ASSIGNED
Comment on attachment 8617430 [details] [diff] [review]
bug-1172100-remove-enable-unittests.patch

Review of attachment 8617430 [details] [diff] [review]:
-----------------------------------------------------------------

Commented-out defaults for several settings change here, but it looks like they are all changed to be consistent with the actual defaults -- a good thing, I think.
Attachment #8617430 - Flags: review?(gbrown) → review+
Comment on attachment 8617430 [details] [diff] [review]
bug-1172100-remove-enable-unittests.patch

Review of attachment 8617430 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for cleaning this up!
Attachment #8617430 - Flags: feedback?(jmaher) → feedback+
https://github.com/mozilla/autophone/commit/06f6444fa9e3908cdaf0eac5019f555c6de74232
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: