1172155 - What should the user see when enabling USB Storage and no UMS devices are available

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Dave Hylands [:dhylands]]

The aries is the first "official" device where we can't share the internal sdcard using UMS (it works fine via MTP).

On the Aries, the external sdcard can be shared via UMS or MTP, and the internal sdcard can only be shared via MTP.

Currently, if you have no sdcard in the phone and you enable USB Storage, nothing appears to happen (since there are no sharable devices).

We should probably make the default be MTP mode for the aries device, but we should probably post a dialog or something if the user tries to enable UMS and not UMS capable devices exist.

So this bug is to find out what the UX should be.

ni? jsavory to adjust this so that that it gets flagged for UX properly.

Comment 1

[Dave Hylands [:dhylands]]

Also ni? Doug to see how important this is for spark.

Comment 2

[Doug Sherk (:drs) (inactive)]

In my opinion, we should go ahead and set the default to MTP, which will be covered in bug 1171556.

Arthur, Yura, do either of you have bandwidth to help us build this dialog? Here's my suggestion for what it should say when attempting to switch to UMS:

======================================

Warning: USB Mass Storage may not work
---

USB Mass Storage will only work
correctly with an external SD card. If
you'd like to be able to access both
your internal and external storage,
you must use MTP.

Press "OK" to switch to USB Mass
Storage, or "Cancel" to remain in MTP
mode.

(Cancel) (OK)

======================================

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hi Dave, 

Is it possible to get the information regarding the support on sharing using UMS from gecko? For devices that can share internal sdcard using UMS the warning seems redundant.

Comment 4

[Doug Sherk (:drs) (inactive)]

We should wait for Dave's reply, but if it isn't favorable for us, we could just special-case this for Aries only for now. We can do this using the "deviceinfo.product_model" setting.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Seems like Arthur took this one, taking myself off ni?

Comment 6

[Dave Hylands [:dhylands]]

(In reply to Arthur Chen [:arthurcc] from comment #3)
> Hi Dave, 
> 
> Is it possible to get the information regarding the support on sharing using
> UMS from gecko? For devices that can share internal sdcard using UMS the
> warning seems redundant.

There is an attribute on each device storage object, called canBeShared, which is referring to being shared via UMS.

So you can call navigator.GetDeviceStorages('sdcard'), enumerate through the returned list for the storage area with the name 'sdcard' and check the canBeShared attribute.

The ds-test app prints the canBeShared attribute for each storage area when you execute 'GetDeviceStorages'

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/30504

Doug, I don't have aries in hand. Could you help try this patch? Thanks!

Comment 8

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8617375 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30504

Hi Arthur. Thanks for this patch. It correctly detects that the SD card slot is not shareable on Aries and displays the warning dialog to me. However, pressing the toggle remains on the UMS option even if you hit "Cancel". From a quick glance at the code, it looks like this is just a cosmetic issue anyways. Other than this, it's perfect. feedback- only because of the bug that I found.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8617375 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30504

EJ, could you help review the patch? Thanks!

Doug, I've fixed the bug you mentioned. Please help check it when you get a chance, thanks!

Comment 10

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8617375 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30504

Works perfectly now, thanks!

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8617375 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30504

Thanks Arthur !! r+ with few nits :)

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ.

master: 5a06fc68e7cb431fe6af9e8a183bfd196612283b

Comment 13

[Ton [:Tonnes]]

(In reply to Doug Sherk (:drs) from comment #2)
> Press "OK" to switch to USB Mass
> Storage, or "Cancel" to remain in MTP
> mode.

Why use "Press" for a non-hardware button instead of "Tap"?

Comment 14

[Jessica]

Attachment: Aries_KK v2.5.png

According to the STR of Comment 0 and Comment 2, this bug has been verified as pass on latest Aries KK v2.5.

Actual results: The corresponding dialog appears when attempting to switch to UMS.
See attachment: Aries_KK v2.5.png
Reproduce rate: 0/6

Device: Aries KK v2.5 (Pass)
Build ID               20151015193337
Gaia Revision          8ea9029190af2ffeb04dcd97b323738125e31a0e
Gaia Date              2015-10-15 14:30:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d374d16cbb251c9dac5af69f8e186e821ce82fe2
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151015.185317
Firmware Date          Thu Oct 15 18:53:25 UTC 2015
Bootloader             s1