WebAudio in "Acid Defender" game is distorted, slows down, and eventually stops

RESOLVED WORKSFORME

Status

()

P2
normal
Rank:
25
RESOLVED WORKSFORME
3 years ago
2 years ago

People

(Reporter: cpeterson, Unassigned)

Tracking

(Depends on: 1 bug, {perf, regression})

unspecified
perf, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 affected, firefox39 affected, firefox40 wontfix, firefox41 wontfix, firefox42 ?, firefox47 unaffected, firefox48 unaffected, firefox49 unaffected, firefox-esr31 affected, firefox-esr45 unaffected, firefox50 unaffected)

Details

(URL)

(Reporter)

Description

3 years ago
STR:
1. Load http://cappel-nord.de/webaudio/acid-defender/
2. Select "Jam Mode".
3. Click a bunch of squares and select all the Kick, Snare, and Hat sound buttons at the bottom.
4. Wait about 20 seconds.

RESULT:
The audio will be distorted, slow down, and eventually stop. This is a regression, but I'm having difficulty bisecting it. The problem is easy reproducible in Nightly 41, somewhat reproducible in 38–40, but not reproducible in ESR 31.

Could this be a regression from OscillatorNode bug 1106649 in Firefox 37?

This might be the same problem I reported in BiquadFilterNode bug 939491.

Comment 1

3 years ago
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b60d1a95bfa3&tochange=b8d51d20fd97

via local build
last good: b60d1a95bfa3
first bad: ffab1d2bd4ce

Triggered by:	ffab1d2bd4ce	Paul Adenot — Bug 1106649 - Use band-limited wave tables to implement basic waveforms. r=karlt
Blocks: 1106649
Keywords: regressionwindow-wanted

Updated

3 years ago
Keywords: perf

Updated

3 years ago
Depends on: 1173016
This should now be fixed in a Nightly build that contains the patches from bug 1173016.
(Reporter)

Comment 3

3 years ago
I'll verify the fix when it lands in Nightly.
status-firefox40: affected → wontfix
status-firefox41: affected → wontfix
status-firefox42: --- → ?
Flags: needinfo?(cpeterson)
(Reporter)

Comment 4

3 years ago
Paul, I can still reproduce this bug in Nightly 42 build 2015-07-10 on my MacBook Pro, though the distortion takes longer (~1 minute) to reproduce than before (~20 seconds).
status-firefox-esr31: unaffected → affected
Flags: needinfo?(cpeterson) → needinfo?(padenot)
Looking at what the app does (using the web audio editor in the devtools), this will be covered by karlt's work on collecting nodes more aggressively/not computing audio for nodes that don't have input. I seem to recall he's starting soon on that, or maybe he's already started, I can't remember the bug number.
Flags: needinfo?(padenot)
And the drop in cpu usage after GC is further evidence.
Depends on: 1189562
Depends on: 1181006
Rank: 25
Priority: -- → P2
(Reporter)

Comment 7

2 years ago
This bug was fixed sometime between Firefox 42 and 45.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox38: ? → affected
status-firefox38.0.5: ? → ---
status-firefox39: ? → affected
status-firefox47: --- → unaffected
status-firefox48: --- → unaffected
status-firefox49: --- → unaffected
status-firefox50: --- → unaffected
status-firefox-esr45: --- → unaffected
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.