Closed
Bug 1172361
Opened 7 years ago
Closed 7 years ago
Change localization of XMPP commands
Categories
(Chat Core :: XMPP, defect)
Chat Core
XMPP
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: abdelrahman, Assigned: abdelrahman, Mentored)
Details
Attachments
(1 file, 1 obsolete file)
2.34 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
Change localiztion of xmpp commands like (join, part) to pass command names as parameters to avoid localization of the command as it is changed.
Assignee | ||
Comment 1•7 years ago
|
||
Updated•7 years ago
|
Summary: Change localiztion of xmpp commands → Change localization of XMPP commands
Comment 2•7 years ago
|
||
Comment on attachment 8616502 [details] [diff] [review] rev 1 - pass command names as parameters Review of attachment 8616502 [details] [diff] [review]: ----------------------------------------------------------------- ::: chat/locales/en-US/xmpp.properties @@ +125,5 @@ > > # LOCALZIATION NOTE (command.*): > # These are the help messages for each command. > +command.join=%S [<room@server>][/<nick>] [<password>]: Join a room, optionally providing a different nickname, or the room password. > +command.part=%S [<message>]: Leave the current room with an optional message. We need to "rev" the names of these so localizers know to re-translate them. I.e. change command.join to command.join2 (and the same for part).
Attachment #8616502 -
Flags: review?(clokep) → review-
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8616502 -
Attachment is obsolete: true
Attachment #8616504 -
Flags: review?(clokep)
Comment 4•7 years ago
|
||
Comment on attachment 8616504 [details] [diff] [review] rev 2 - pass command names as parameters Review of attachment 8616504 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8616504 -
Flags: review?(clokep) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•