Closed Bug 1172361 Opened 5 years ago Closed 5 years ago

Change localization of XMPP commands

Categories

(Chat Core :: XMPP, defect)

Product:
Chat Core
Component:
XMPP
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: abdelrahman, Assigned: abdelrahman, Mentored)

Details

Attachments

(1 file, 1 obsolete file)

rev 2 - pass command names as parameters
2.34 KB, patch
clokep
: review+
Details | Diff | Splinter Review 
Change localiztion of xmpp commands like (join, part) to pass command names as parameters to avoid localization of the command as it is changed.
Assignee: nobody → a.ahmed1026
Status: NEW → ASSIGNED
Attachment #8616502 - Flags: review?(clokep)
Summary: Change localiztion of xmpp commands → Change localization of XMPP commands
Comment on attachment 8616502 [details] [diff] [review]
rev 1 - pass command names as parameters

Review of attachment 8616502 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/locales/en-US/xmpp.properties
@@ +125,5 @@
>  
>  # LOCALZIATION NOTE (command.*):
>  #  These are the help messages for each command.
> +command.join=%S [<room@server>][/<nick>] [<password>]: Join a room, optionally providing a different nickname, or the room password.
> +command.part=%S [<message>]: Leave the current room with an optional message.

We need to "rev" the names of these so localizers know to re-translate them. I.e. change command.join to command.join2 (and the same for part).
Attachment #8616502 - Flags: review?(clokep) → review-
Attachment #8616502 - Attachment is obsolete: true
Attachment #8616504 - Flags: review?(clokep)
Comment on attachment 8616504 [details] [diff] [review]
rev 2 - pass command names as parameters

Review of attachment 8616504 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8616504 - Flags: review?(clokep) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.