1172372 - Increase spread of rule priorities to allow more room for special cases

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We're using an limited range of priorities from 90 to 100, and are starting to run out of room for all the special cases that come along. I'm proposing we increase the priorities of the OS blocking and watershed rules to create more room. This also helps us avoid using the same priority on more than rule, because that makes it harder to reason about which one will apply.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Here's the worst offender:
+---------+----------+--------------------------------+---------+---------+----------+
| rule_id | priority | mapping                        | product | version | channel  |
+---------+----------+--------------------------------+---------+---------+----------+
|      69 |      100 | No-Update                      | NULL    | NULL    | release* | # OS deprecation
|     103 |       95 | No-Update                      | Firefox | <4.0    | release  | # old builds
|      73 |       93 | Firefox-12.0-build1            | Firefox | <10.0   | release* | # watershed, old XP
|     184 |       92 | Firefox-38.0.5-build4-whatsnew | Firefox | NULL    | release  | # pocket locales
|     145 |       90 | Firefox-38.0.5-build4          | Firefox | NULL    | release  | # normal update
+---------+----------+--------------------------------+---------+---------+----------+

For Firefox 38.0.6 we need another couple of rules between the 12.0 watershed and the 38.0.5 vanilla builds. And for bug 998721 we'll need a couple more between the <4.0 and 12.0.

So I've done this:
+---------+----------+--------------------------------+---------+---------+----------+
| rule_id | priority | mapping                        | product | version | channel  |
+---------+----------+--------------------------------+---------+---------+----------+
|      69 |      150 | No-Update                      | NULL    | NULL    | release* | # OS deprecation
|     103 |      120 | No-Update                      | Firefox | <4.0    | release  | # old builds
|      73 |      110 | Firefox-12.0-build1            | Firefox | <10.0   | release* | # watershed, old XP
|     184 |       92 | Firefox-38.0.5-build4-whatsnew | Firefox | NULL    | release  | # pocket locales
|     145 |       90 | Firefox-38.0.5-build4          | Firefox | NULL    | release  | # normal update
+---------+----------+--------------------------------+---------+---------+----------+

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

After doing some spot checks, and checking newrelic, this looks to be working fine.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Documenting other changes:
* rule_id 103 changed from channel of 'release' to 'release*' (this is the block for builds older than 4.0)
* removed rule for Firefox releasetest <2.0 pointing to Firefox-2.0.0.20