Closed
Bug 1172382
Opened 9 years ago
Closed 9 years ago
Enable AccessibleCaret on B2G and fix test case failures if any
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla42
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
2.92 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
7.79 KB,
patch
|
TYLin
:
review+
|
Details | Diff | Splinter Review |
On B2G, enable the new "layout.accessiblecaret.enabled" and disable old "touchcaret.enabled" and "selectioncaret.enabled".
Assignee | ||
Comment 1•9 years ago
|
||
The new AccessibleCaret replaces TouchCaret and SelectionCarets. Disable them accordingly. https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e78d7644e3c
Assignee | ||
Comment 2•9 years ago
|
||
All the tests disabled for AccessibleCaret had already being disabled for either TouchCaret or SelectionCarets. https://treeherder.mozilla.org/#/jobs?repo=try&revision=48bf24165843
Assignee | ||
Updated•9 years ago
|
Attachment #8623497 -
Flags: review?(roc)
Assignee | ||
Updated•9 years ago
|
Attachment #8625213 -
Flags: review?(roc)
Attachment #8623497 -
Flags: review?(roc) → review+
Attachment #8625213 -
Flags: review?(roc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e6edadb0d1 https://hg.mozilla.org/integration/mozilla-inbound/rev/d4b6f85c0d42
Assignee | ||
Comment 4•9 years ago
|
||
Try results looks good with the patch in bug 1147329. https://bugzilla.mozilla.org/show_bug.cgi?id=1147329#c40
Comment 5•9 years ago
|
||
sorry had to back this out for test failurs like https://treeherder.mozilla.org/logviewer.html#?job_id=12134883&repo=mozilla-inbound
Flags: needinfo?(tlin)
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/00118b172683 https://hg.mozilla.org/integration/mozilla-inbound/rev/7d43dde74d52
Assignee | ||
Comment 7•9 years ago
|
||
Tomcat, sorry about that. I forgot to test Mulut on try.
Flags: needinfo?(tlin)
Assignee | ||
Comment 8•9 years ago
|
||
Fix Mulut test failure by disabling AccessibleCaret in editor/reftests/reftest.list. Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=09a6d2f62b43
Attachment #8625213 -
Attachment is obsolete: true
Attachment #8639211 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/afc3da30cbb1 https://hg.mozilla.org/integration/mozilla-inbound/rev/13ca1aa4484d
Keywords: checkin-needed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/afc3da30cbb1 https://hg.mozilla.org/mozilla-central/rev/13ca1aa4484d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•