Closed Bug 1172383 Opened 6 years ago Closed 6 years ago

Stop mDNS service when nsDNSServiceDiscovery is being destructed

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
FxOS-S6 (04Sep)
Tracking Status
firefox43 --- fixed

People

(Reporter: xeonchen, Assigned: kershaw)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 2 obsolete files)

|nsDNSServiceDiscovery| tries to start mDNS service at initialization, but never stop it.
The reason is that the service is not ref-counted, and stop the service directly might cause unexpected behavior.

However, in b2g environment, we can define |nsDNSServiceDiscovery| as the only operator to mDNS service.
That means |nsDNSServiceDiscovery| should stop mDNS properly during destruction.
Whiteboard: [good first bug]
Attached patch stop mDNS (obsolete) — Splinter Review
Hi Gary,

Could you please take a quick look?

Thanks.
Assignee: nobody → kechang
Attachment #8652170 - Flags: feedback?(xeonchen)
Comment on attachment 8652170 [details] [diff] [review]
stop mDNS

Review of attachment 8652170 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks.
Attachment #8652170 - Flags: feedback?(xeonchen) → feedback+
Attachment #8652170 - Attachment is obsolete: true
Attachment #8652236 - Flags: review?(mcmanus)
See Also: → 1199564
Attachment #8652236 - Flags: review?(mcmanus) → review+
Thanks for reviewing this.
Attachment #8652236 - Attachment is obsolete: true
Attachment #8655861 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/55891637b379
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S6 (04Sep)
You need to log in before you can comment on or make changes to this bug.