Closed
Bug 1172383
Opened 10 years ago
Closed 9 years ago
Stop mDNS service when nsDNSServiceDiscovery is being destructed
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
FxOS-S6 (04Sep)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: xeonchen, Assigned: kershaw)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 2 obsolete files)
1.60 KB,
patch
|
kershaw
:
review+
|
Details | Diff | Splinter Review |
|nsDNSServiceDiscovery| tries to start mDNS service at initialization, but never stop it.
The reason is that the service is not ref-counted, and stop the service directly might cause unexpected behavior.
However, in b2g environment, we can define |nsDNSServiceDiscovery| as the only operator to mDNS service.
That means |nsDNSServiceDiscovery| should stop mDNS properly during destruction.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [good first bug]
See Also: → 1194532
Assignee | ||
Comment 1•9 years ago
|
||
Hi Gary,
Could you please take a quick look?
Thanks.
Assignee: nobody → kechang
Attachment #8652170 -
Flags: feedback?(xeonchen)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8652170 [details] [diff] [review]
stop mDNS
Review of attachment 8652170 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, thanks.
Attachment #8652170 -
Flags: feedback?(xeonchen) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8652170 -
Attachment is obsolete: true
Attachment #8652236 -
Flags: review?(mcmanus)
Updated•9 years ago
|
Attachment #8652236 -
Flags: review?(mcmanus) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks for reviewing this.
Attachment #8652236 -
Attachment is obsolete: true
Attachment #8655861 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S6 (04Sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•