Closed
Bug 1172473
Opened 10 years ago
Closed 10 years ago
Intermittent browser_607016.js | (deleting) uniq not in existing extData -
Categories
(Firefox :: Session Restore, defect)
Tracking
()
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
| firefox41 | --- | fixed |
| firefox42 | --- | fixed |
| firefox-esr31 | --- | unaffected |
| firefox-esr38 | --- | unaffected |
People
(Reporter: cbook, Assigned: ttaubert)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
|
6.12 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
mozilla-inbound_xp-ix_test_pgo-mochitest-browser-chrome-1
https://treeherder.mozilla.org/logviewer.html#?job_id=10515011&repo=mozilla-inbound
16:09:56 INFO - 1639 INFO TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_607016.js | (deleting) uniq not in existing extData -
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 35•10 years ago
|
||
Tim, can you please look into this and bug 1181280?
Flags: needinfo?(ttaubert)
See Also: → 1181280
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Flags: needinfo?(ttaubert)
| Assignee | ||
Comment 37•10 years ago
|
||
I tried to keep the original test mostly intact but the progress listener didn't really work for some reason. Well, I left it better than I found it.
Attachment #8634677 -
Flags: review?(mconley)
Comment 38•10 years ago
|
||
Comment on attachment 8634677 [details] [diff] [review]
0001-Bug-1172473-Fix-intermittent-browser_607016.js-failu.patch
Review of attachment 8634677 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Thanks!
::: browser/components/sessionstore/test/browser_607016.js
@@ +6,2 @@
> /** Bug 607016 - If a tab is never restored, attributes (eg. hidden) aren't updated correctly **/
> waitForExplicitFinish();
Shouldn't need this anymore, I don't think.
Attachment #8634677 -
Flags: review?(mconley) → review+
| Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 41•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Updated•10 years ago
|
status-firefox40:
--- → affected
status-firefox41:
--- → affected
status-firefox-esr31:
--- → unaffected
status-firefox-esr38:
--- → unaffected
Comment 42•10 years ago
|
||
Comment 43•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•