1172524 - Remote Tabs Home Panel should not hit the network every time

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Currently we always reload your tabs by hitting the network. Instead we should implement some simple heuristic that shows the already synced tabs if the last sync time was within a specific time period.

Comment 2

[Richard Newman [:rnewman]]

Duped bug is tracking, so carrying over flag and assignee.

Comment 3

[Stephan Leroux [:sleroux]]

I remember you mentioned you had an idea around this bug. I took a look through the sync code and found the TabSynchronizer's lastFetched Timestamp we're using to store the last fetch time. What are you thoughts on exposing this in the SyncManager vs. keeping the re-download heuristic internal to the sync framework?

Comment 4

[Richard Newman [:rnewman]]

lastFetched is a server timestamp, so we can't use that. (Which is one reason why it's not exposed.)

We should be just saving some local clock timestamp in a successful refresh(), like barbarians.

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/649

This patch adds some throttling behind refreshing of the client/tabs on the RemoteTabsPanel so we're not hitting the network every time. Instead, a one minute delay is used since the last sync time.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8627185 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/649

Comments on the PR.

Comment 7

[Stephan Leroux [:sleroux]]

Merged.