Closed
Bug 1172725
Opened 11 years ago
Closed 11 years ago
allow enabling WX exclusive to compile
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
DUPLICATE
of bug 977805
People
(Reporter: tedu, Unassigned)
Details
Attachments
(1 file)
|
724 bytes,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; OpenBSD amd64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150403111657
Steps to reproduce:
Try to compile with ENABLE_ASSEMBLER_WX_EXCLUSIVE defined to 1.
Actual results:
Compilation fails because ExecutableAllocatorPosix.cpp 1: checks the wrong macro and 2: has a silly typo in the code.
Expected results:
It should compile. This is, by itself, not especially meaningful, but it's very simple and obvious to fix. Trying to make use of this option for other work requires that it compile. Patch attached.
Attachment #8616994 -
Attachment mime type: text/x-patch → text/plain
Attachment #8616994 -
Attachment is patch: true
Attachment #8616994 -
Flags: review?(wmccloskey)
Attachment #8616994 -
Flags: review?(wmccloskey) → review?(jdemooij)
|
||
Comment 1•11 years ago
|
||
Hi Ted! Thank you for the patch but I happen to be fixing this issue right now, in bug 977805! I'll post a patch there soon :)
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
|
|
||
Updated•11 years ago
|
Attachment #8616994 -
Flags: review?(jdemooij)
You need to log in
before you can comment on or make changes to this bug.
Description
•