1172779 - Customizer Launcher displays "Communications" instead of "Dialer" and "Contacts"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)

Description

[Doug Sherk (:drs) (inactive)]

User-Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

We should just hard code the handling for these apps. It's not worth properly handling multiple entry points.

Comment 1

[Doug Sherk (:drs) (inactive)]

Punam, can you take this?

Note that the Communications app is the only one that still uses "entry_points" in the manifest. That's why I suggested hardcoding in the Dialer and Contacts apps, rather than parsing the "entry_points".

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: PR with fix of Bug1172779

Hi Justin

Attaching patch that shows Dialer and Contacts app in CL in place of Communications. Patch also addresses UI fix asked in https://bugzilla.mozilla.org/show_bug.cgi?id=1133943#c13 for CL.
Please review. Thanks!

Comment 3

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8621705 [details] [review]
PR with fix of Bug1172779

Left some comments in the PR and talked with Punam on IRC about making this a bit more dynamic and not keying off the `name`.

Comment 4

[Punam Dahiya [:pdahiya]]

Comment on attachment 8621705 [details] [review]
PR with fix of Bug1172779

Hi Justin

Setting review flag on the patch updated with feedback. Please review. Thanks!

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8621705 [details] [review]
PR with fix of Bug1172779

Much better! I left one comment on the PR that points out a small change that might make this work for apps other than "communications" that use entry points (although, I'm not aware of any others ATM).

Comment 6

[Punam Dahiya [:pdahiya]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #5)
> Comment on attachment 8621705 [details] [review]
> PR with fix of Bug1172779
> 
> Much better! I left one comment on the PR that points out a small change
> that might make this work for apps other than "communications" that use
> entry points (although, I'm not aware of any others ATM).

Updated patch in favor of removing hard coded communications mainfest url with app.manifest.entry_points to make it generic for parsing all apps with entry_points.

Comment 7

[Punam Dahiya [:pdahiya]]

Patch landed on master

https://github.com/fxos/customizer-launcher/commit/d798c2fd05cf883d69686b277b1c9c9a42a0261e