Closed
Bug 1172847
Opened 9 years ago
Closed 9 years ago
'Let’s Talk About' hard to see in conversation window after someone joins the conversation due to its color
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox40+ verified, firefox41 unaffected, firefox42 unaffected)
Tracking | Status | |
---|---|---|
firefox40 | + | verified |
firefox41 | --- | unaffected |
firefox42 | --- | unaffected |
People
(Reporter: bmaris, Assigned: mikedeboer)
References
Details
(Whiteboard: [ux bug])
Attachments
(2 files)
81.10 KB,
image/jpeg
|
Details | |
967 bytes,
patch
|
dmosedale
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Affected builds: - Latest Nightly 41.0a1 - Latest Aurora 40.0a2 Affected OS`s: - Windows 7 64-bit - Mac OS X 10.9.5 - Ubuntu 14.04 32-bit STR: 1. Start Firefox 2. Visit a website and tick 'Let’s Talk About' 3. Start a conversation 4. Join the conversation from same or different PC Expected results: 'Let’s Talk About' visible in conversation window. Actual results: 'Let’s Talk About' is colored black and it`s very hard to see. Notes: - Screenshot showing the issue: image from left is before bug 1162909 and image from right is the actual behavior. - This is not a regression, it reproduces after context layout changes in bug 1162909.
Updated•9 years ago
|
Rank: 24
Flags: qe-verify+
Flags: firefox-backlog+
Priority: -- → P2
Whiteboard: [ux bug]
Assignee | ||
Comment 1•9 years ago
|
||
This will be fixed by the redesign in bug 1171940.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 2•9 years ago
|
||
Re-opening and make it apply only to Fx 40. Other (newer) versions of Fx will be fixed by bug 1171940, as stated in comment 1.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 3•9 years ago
|
||
[Tracking Requested - why for this release]: Nominating Hello Conversation Context issues for 40.
Iteration: --- → 42.2 - Jul 27
Points: --- → 1
status-firefox40:
--- → affected
status-firefox41:
--- → unaffected
status-firefox42:
--- → unaffected
tracking-firefox40:
--- → ?
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mdeboer
Status: REOPENED → ASSIGNED
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8634069 -
Flags: review?(dmose)
Comment 5•9 years ago
|
||
Comment on attachment 8634069 [details] [diff] [review] Patch v1: make sure that the color of context in conversations label is white. Beta-only! Review of attachment 8634069 [details] [diff] [review]: ----------------------------------------------------------------- r=dmose; thanks for the quick patch!
Attachment #8634069 -
Flags: review?(dmose) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8634069 [details] [diff] [review] Patch v1: make sure that the color of context in conversations label is white. Beta-only! Approval Request Comment [Feature/regressing bug #]: Hello context in conversations feature [User impact if declined]: When the conversation is connected on both sides and the context view is visible in the conversation window, the label is barely visible, because it's color is black. There was a CSS rule missing, which this patch puts in place. [Describe test coverage new/current, TreeHerder]: zip, since m-a does not exhibit this bug once bug 1171940 is uplifted there. [Risks and why]: minor, this is quite possibly the simplest CSS change you can imagine. [String/UUID change made/needed]: n/a.
Attachment #8634069 -
Flags: approval-mozilla-beta?
Comment 7•9 years ago
|
||
Comment on attachment 8634069 [details] [diff] [review] Patch v1: make sure that the color of context in conversations label is white. Beta-only! We want this new feature to be polished, taking it.
Attachment #8634069 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Reporter | ||
Comment 10•9 years ago
|
||
Verified that the issue is fixed on Firefox 40 beta 6 across platforms (Windows 10 32-bit, Windows 8.1 64-bit, Mac OS X 10.10 and Ubuntu 14.04 32-bit).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•