1172847 - 'Let’s Talk About' hard to see in conversation window after someone joins the conversation due to its color

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screenshot showing the issue

Affected builds:
- Latest Nightly 41.0a1
- Latest Aurora 40.0a2

Affected OS`s:
- Windows 7 64-bit
- Mac OS X 10.9.5
- Ubuntu 14.04 32-bit

STR:
1. Start Firefox
2. Visit a website and tick 'Let’s Talk About'
3. Start a conversation
4. Join the conversation from same or different PC

Expected results: 'Let’s Talk About' visible in conversation window.

Actual results: 'Let’s Talk About' is colored black and it`s very hard to see.

Notes:
- Screenshot showing the issue: image from left is before bug 1162909 and image from right is the actual behavior.
- This is not a regression, it reproduces after context layout changes in bug 1162909.

Comment 1

[Mike de Boer [:mikedeboer]]

This will be fixed by the redesign in bug 1171940.

Comment 2

[Mike de Boer [:mikedeboer]]

Re-opening and make it apply only to Fx 40. Other (newer) versions of Fx will be fixed by bug 1171940, as stated in comment 1.

Comment 3

[Mike de Boer [:mikedeboer]]

[Tracking Requested - why for this release]:
Nominating Hello Conversation Context issues for 40.

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: make sure that the color of context in conversations label is white. Beta-only!

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8634069 [details] [diff] [review]
Patch v1: make sure that the color of context in conversations label is white. Beta-only!

Review of attachment 8634069 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose; thanks for the quick patch!

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8634069 [details] [diff] [review]
Patch v1: make sure that the color of context in conversations label is white. Beta-only!

Approval Request Comment
[Feature/regressing bug #]: Hello context in conversations feature
[User impact if declined]: When the conversation is connected on both sides and the context view is visible in the conversation window, the label is barely visible, because it's color is black. There was a CSS rule missing, which this patch puts in place.
[Describe test coverage new/current, TreeHerder]: zip, since m-a does not exhibit this bug once bug 1171940 is uplifted there.
[Risks and why]: minor, this is quite possibly the simplest CSS change you can imagine.
[String/UUID change made/needed]: n/a.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8634069 [details] [diff] [review]
Patch v1: make sure that the color of context in conversations label is white. Beta-only!

We want this new feature to be polished, taking it.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d5d7f2fc0f7

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

This has already landed in 40. Tracking in case this is reopened.

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Verified that the issue is fixed on Firefox 40 beta 6 across platforms (Windows 10 32-bit, Windows 8.1 64-bit, Mac OS X 10.10 and Ubuntu 14.04 32-bit).