1172888 - Preference 'extensions.bootstrappedAddons' not updated properly.

Status: RESOLVED DUPLICATE of bug 1171173

(Toolkit :: Add-ons Manager, defect)

Description

[Gary [:streetwolf52]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150608193020

Steps to reproduce:

1. Install the e10s LastPass extension found at https://rodan.lastpass.com/dev/lp_e10s.xpi
 
2. Per https://bugzilla.mozilla.org/show_bug.cgi?id=1168597#c3 add 
<em:multiprocessCompatible>true</em:multiprocessCompatible> to LastPass install.rdf file to get rid of the shim that is causing the text filling problem described in the bug report.

3. Start Fx41


Actual results:

After adding the statement to install.rdf the text problem goes away unitl I restart Fx41.  The problem then appears all the time.  Updating the install.rdf file seems to have made it work temporarily.

Inspecting the preference 'extensions.bootstrappedAddons' right after I updated the install.rdf I noticed the entry for LastPass has multiprocessCompatible set to true.  After I restart Fx it returns to false even though the install.rdf still has multiprocessCompatible set to true.  This, I believe, is why the text fill problem returns.


Expected results:

The shim for LastPass should be disabled permanently and the text fill problem fixed as a workaround.

Note: I have other extensions that also have multiprocessCompatible set to true in their install.rdf but they are not affected like LastPass.

Comment 1

[Gary [:streetwolf52]]

Did some additional testing and it appears that if I change any file in the LP package, save it, and start Fx the shim is disabled and the slow text problem is eliminated.  Restarting Fx breaks things and the shim is enabled again.  The changes I made were identical so I didn't add anything new.  I guess anything that 'changes' the LP package will do this.

Comment 2

[Gary [:streetwolf52]]

Just installed a new version of LastPass for e10s and the text problem is gone.  They didn't add <em:multiprocessCompatible>true</em:multiprocessCompatible> to their install.rdf and the pref 'extensions.bootstrappedAddons' still shows multiprocessCompatible as False so I guess I was wrong on that.

Anyways the slow text and fill in issue seems to be fixed for now.  I'll close this. 


Version: 3.1.95
Built: 2015-06-09 10:30:37
Binary Component: true (ctypes version 3.1.97, built Apr 16 2015 16:02:24)

Comment 3

[Dave Townsend [:mossop]]

I'm reopening this for investigation. Shims being turned back on after a restart sounds like a bug regardless of whether it breaks lastpass right now.

Comment 4

[atlanto]

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIProvider.jsm#709
createAddonDetails() doesn't set multiprocessCompatible.
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIProvider.jsm#2375
the insufficient data is passed to callBootstrapMethod().
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIProvider.jsm#4627
>aAddon.multiprocessCompatible || false
this returns always false.

This bug is causing bug 1171173.
(uBlock addon has multiprocessCompatible:true in its install.rdf)
(disable/enable resets multiprocessCompatible to correct value)

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Sorry, I somehow missed comment  4. It was indeed the problem. Thanks for tracking it down.