1172986 - Show message if no plugins was detected

Status: RESOLVED FIXED

(Plugin Check Graveyard :: UI, defect, P1)

Description

[Schalk Neethling [:espressive]]

Currently there is no message shown to users if they have no plugins installed. This is rare but, it does happen.

I propose we add the following:

"No plugins was detected. If you believe this to be in error, please log a bug and let us know"

We can then have it link to bugzilla where a user can tell us which plugins they *do* have installed but, was not detected.

This does have an l10n impact so, looping in :flod

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Schalk Neethling [:espressive] from comment #0)
> "No plugins was detected. If you believe this to be in error, please log a
> bug and let us know"

Not a native speaker, but this sounds strange ("was detected", "log a bug"). I'd suggest to get a copy review before looking into code.

We should probably try to get a look at the status of tags and localizations, this page is starting to have way too many tags.

Comment 2

[Schalk Neethling [:espressive]]

Yeah I agree, probably something like:

"No plugins were found. If you believe this to be in error, please file a bug and let us know."

I agree, we need to have a look at all the tags and see which are still needed etc.

Comment 3

[Francesco Lodolo [:flod]]

Re Tags.

Removed 'java_notice' and related strings from lang file, since they're not in use anymore.

We only have 4 locales with 'plugin_disable_warning', we should associate these strings to 'plugin_updated_content' (10 locales).

Use one tag for 'meta_update_201503', 'share_cta', 'plugincheck_nosupport'. Even if it might be confusing, using 'plugincheck_nosupport' for all the strings helps not breaking the site on production while we wait for a push to prod.

If you prefer I can do the PR to fix that part.

Comment 4

[Francesco Lodolo [:flod]]

BTW, this is the code I use to check the available groups of tags
https://gist.github.com/flodolo/575245a97054e99b41e0

Comment 5

[Jennifer Bertsch [:jbertsch]]

(In reply to Schalk Neethling [:espressive] from comment #2)
> Yeah I agree, probably something like:
> 
> "No plugins were found. If you believe this to be in error, please file a
> bug and let us know."
> 
> I agree, we need to have a look at all the tags and see which are still
> needed etc.

+1 thanks and sorry for the slow reply

Comment 6

[Schalk Neethling [:espressive]]

The tags have been cleaned up. :flod, you okay with me proceeding with this bug?

Jen, are you happy with the following copy:

"No plugins were found. If you believe this to be in error, please file a bug and let us know."

If not, who should I loop in to take a look? Thanks!

Comment 7

[Francesco Lodolo [:flod]]

Yes, OK to go. I'd suggest to ask matej for advice on copy.

Comment 8

[Schalk Neethling [:espressive]]

Thanks :flod!

Matej, can you have a look at the suggested copy here https://bugzilla.mozilla.org/show_bug.cgi?id=1172986#c6 and let me know if you have any suggested changes or improvements. Thanks!

Comment 9

[Matej Novak [:matej]]

(In reply to Schalk Neethling [:espressive] from comment #8)
> Thanks :flod!
> 
> Matej, can you have a look at the suggested copy here
> https://bugzilla.mozilla.org/show_bug.cgi?id=1172986#c6 and let me know if
> you have any suggested changes or improvements. Thanks!

Just a slight tweak:

"No plugins were found. If you believe this is an error, please file a bug and let us know."

Thanks.

Comment 10

[Dan Pernokis]

Just a comment from outside...
Comments 6 & 9 are both good and correct, but Comment 9 is my preference.  The tense is simpler and it's a little less formal.

Comment 11

[Schalk Neethling [:espressive]]

Thanks All, I will get this live asap.

Comment 12

[Schalk Neethling [:espressive]]

Attachment: Link to Github pull-request: https://github.com/mozilla/bedrock/pull/3159

Comment 13

[Jennifer Bertsch [:jbertsch]]

clearing NI

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/1a8ac8aa13d991afe65e4344205049734a3b5d23
Fix Bug 1172986, show message when no plugins are found

https://github.com/mozilla/bedrock/commit/84749412aa6f60ea85bb4156914485c6c81937cc
Merge pull request #3159 from schalkneethling/bug1172986-show-message-when-no-plugins-detected

Fix Bug 1172986, show message when no plugins are found