1173022 - [EME] crash in mozilla::gmp::GMPVideoEncodedFrameImpl::RelinquishFrameData(mozilla::gmp::GMPVideoEncodedFrameData&)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Chris Peterson [:cpeterson]]

This bug was filed from the Socorro interface and is 
report bp-aa0c7776-791f-435c-b0f6-618552150609.
=============================================================

I hit this crash when trying to reproduce bug 1164245 comment 12. Looks like GMPVideoDecoderParent::Decode() parameter aInputFrame, a UniquePtr, held a null pointer.

Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::gmp::GMPVideoEncodedFrameImpl::RelinquishFrameData(mozilla::gmp::GMPVideoEncodedFrameData&) 	dom/media/gmp/GMPVideoEncodedFrameImpl.cpp
1 	xul.dll 	mozilla::gmp::GMPVideoDecoderParent::Decode(mozilla::UniquePtr<GMPVideoEncodedFrame, mozilla::DestroyPolicy<GMPVideoEncodedFrame> >, bool, nsTArray<unsigned char> const&, __int64) 	dom/media/gmp/GMPVideoDecoderParent.cpp
2 	xul.dll 	mozilla::dom::TestGMPVideoDecoder::InitGMPDone(GMPVideoDecoderProxy*, GMPVideoHost*) 	dom/media/eme/GMPVideoDecoderTrialCreator.cpp
3 	xul.dll 	nsRunnableMethodImpl<void ( nsJARChannel::*)(unsigned __int64), 1, unsigned __int64>::Run() 	xpcom/glue/nsThreadUtils.h
4 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp
5 	xul.dll 	NS_ProcessNextEvent(nsIThread*, bool) 	xpcom/glue/nsThreadUtils.cpp
6 	xul.dll 	mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp
7 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc
8 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc
9 	xul.dll 	nsThread::ThreadFunc(void*) 	xpcom/threads/nsThread.cpp
10 	nss3.dll 	_PR_NativeRunThread 	nsprpub/pr/src/threads/combined/pruthr.c
11 	nss3.dll 	pr_root 	nsprpub/pr/src/md/windows/w95thred.c
12 	msvcr120.dll 	_callthreadstartex 	f:\dd\vctools\crt\crtw32\startup\threadex.c:376
13 	msvcr120.dll 	msvcr120.dll@0x2c000 	
Ø 14 	kernel32.dll 	kernel32.dll@0x13223 	
Ø 15 	ntdll.dll 	ntdll.dll@0x5fa13 	
Ø 16 	ntdll.dll 	ntdll.dll@0x5f9de

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Edwin: Can you look at this when you get time please?

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

I believe I fixed this with bug 1184333 patch 1.