Closed
Bug 1173104
Opened 10 years ago
Closed 10 years ago
[Contacts][NGA] Extract 'isEmpty' out of contacts.js
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S1 (26Jun)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: borjasalguero, Assigned: fcampo)
References
Details
(Whiteboard: [NG Gaia Contacts])
Attachments
(1 file)
Move this functionality to a separate 'utilities' file.
|
||
Updated•10 years ago
|
Whiteboard: [NG Gaia Contacts]
|
|
||
Updated•10 years ago
|
Target Milestone: --- → NGA S2 (12Jun)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → fernando.campo
|
|
||
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8617949 -
Flags: review?(francisco)
Attachment #8617949 -
Flags: review?(borja.bugzilla)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8617949 [details] [review]
PullRequest: https://github.com/mozilla-b2g/gaia/pull/30521
Great job!
Attachment #8617949 -
Flags: review?(borja.bugzilla) → review+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8617949 [details] [review]
PullRequest: https://github.com/mozilla-b2g/gaia/pull/30521
Left some comments on gh, mainly nits for renaming. But my main concern is removing the load of this new file in the bootstrap as it is the critical path and it's not needed until we load the detail or form views.
:borjasalguero also asked for some feedback on my comments in gh.
Thanks folks!
Attachment #8617949 -
Flags: review?(francisco)
|
|
||
Comment 4•10 years ago
|
||
:Borja please read comment #3, about the suggestions done in GH.
Flags: needinfo?(borja.bugzilla)
|
|
Reporter | |
Comment 5•10 years ago
|
||
Yep, I think that moving to the 'loading' path of every view could save some milliseconds, so let's do it!
Flags: needinfo?(borja.bugzilla)
|
|
||
Updated•10 years ago
|
Target Milestone: NGA S2 (12Jun) → NGA S3 (26Jun)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Comment on attachment 8617949 [details] [review]
PullRequest: https://github.com/mozilla-b2g/gaia/pull/30521
Finally tests are green again, please re-review the latest changes following your comments
Attachment #8617949 -
Flags: review?(francisco)
|
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8617949 [details] [review]
PullRequest: https://github.com/mozilla-b2g/gaia/pull/30521
LGTM, tried on the phone and working fine :)
Thanks Fernando.
Attachment #8617949 -
Flags: review?(francisco) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
status-b2g-master:
--- → fixed
|
|
||
Comment 9•10 years ago
|
||
As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
You need to log in
before you can comment on or make changes to this bug.
Description
•