1173106 - [Contacts][NGA] Move contacts.Matcher to it own Object.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Borja Salguero [:borjasalguero]]

Remove dependencies from contacts. 'Matcher' must be a separate object from 'contacts.js'.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[Borja Salguero [:borjasalguero]]

Comment on attachment 8617873 [details] [review]
Pull Request

Let's start removing all dependencies from 'contacts.js'! Francisco, could you take a look? Thanks!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hei Borja,

really good patch, I like the idea to remove the `contacts` namespace. Should we keep everything, both new classes Matcher and MatcheObj exported from the same file?

So we won't need to read another file (saving some time), the file `contacts_matcher.js` could export both.

What do you think?

Comment 4

[Borja Salguero [:borjasalguero]]

In this case I would have one '.js' file per 'object' exported. It's tough to search in the code if a '.js' file is exporting more than one Object at the same time.
I've found that MatcherObj is needed in 'global_contacts_data.js', and that's why I've separated it in a different file (my first approach was exporting just a 'Matcher').

Comment 5

[Borja Salguero [:borjasalguero]]

After talking with Francisco, we are going to remove 'GlobalContactsData', so no 'MatcherObj' is needed out of the 'Matcher' object. I've updated the patch with this, so now it's ready to be reviewed! :)

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8617873 [details] [review]
Pull Request

Tested on the phone and looking great.

Thanks Borja.

Comment 7

[Borja Salguero [:borjasalguero]]

Thanks Francisco!