Closed Bug 1173120 Opened 6 years ago Closed 6 years ago
ADB ._run Cmd() does not use a timeout
http://hg.mozilla.org/mozilla-central/annotate/517791f65cd9/testing/mozbase/mozdevice/mozdevice/devicemanagerADB.py#l542 devicemanagerADB's _runCmd() does not take a timeout argument and does not use a timeout argument when calling ProcessHander.run() -- unlike _checkCmd() and perhaps some other places. I think that means that an adb hang will translate into a test harness hang, resulting in the dreaded buildbot 2400 seconds without output timeout in automation.
This updates devicemanagerADB's _runCmd to use a time-out when running adb -- just like _checkCmd, after bug 1172174.
Attachment #8620989 - Flags: review?(armenzg)
You need to log in before you can comment on or make changes to this bug.