1173127 - Remove sidebar toggle

Status: RESOLVED INVALID

(DevTools Graveyard :: WebIDE, defect)

Description

[Jen Fong-Adwent [:ednapiranha]]

Remove |devtools.webide.sidebars| and clean up references to the preference flag in the code

- Remove references in webide.js
- Remove sidebars/ test directory and references to that dir

Comment 1

[Alfred Kayser]

As long as "devtools.webide.sidebars" is there, the toggle buttons should only be visible when that preference is not true.

Comment 2

[Alfred Kayser]

This is duplicate of 1139482?

Comment 3

[Jen Fong-Adwent [:ednapiranha]]

(In reply to Alfred Kayser from comment #2)
> This is duplicate of 1139482?

Nope, originally the meta bug 1139482 was the one that would contain all the fixes that are being filed now. We're breaking them up into smaller pieces so that we can have smaller, manageable pieces for potential new contributors and/or our team to fix.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Jen Fong-Adwent [:ednapiranha] from comment #3)
> (In reply to Alfred Kayser from comment #2)
> > This is duplicate of 1139482?
> 
> Nope, originally the meta bug 1139482 was the one that would contain all the
> fixes that are being filed now. We're breaking them up into smaller pieces
> so that we can have smaller, manageable pieces for potential new
> contributors and/or our team to fix.

So bug 1139482 is a meta bug?  You should add the keyword "meta", and probably also prefix the bug title with "[meta]" to match current convention.

Also, should this bug block the meta bug then?

Comment 5

[Jen Fong-Adwent [:ednapiranha]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> (In reply to Jen Fong-Adwent [:ednapiranha] from comment #3)
> > (In reply to Alfred Kayser from comment #2)
> > > This is duplicate of 1139482?
> > 
> > Nope, originally the meta bug 1139482 was the one that would contain all the
> > fixes that are being filed now. We're breaking them up into smaller pieces
> > so that we can have smaller, manageable pieces for potential new
> > contributors and/or our team to fix.
> 
> So bug 1139482 is a meta bug?  You should add the keyword "meta", and
> probably also prefix the bug title with "[meta]" to match current convention.
> 
> Also, should this bug block the meta bug then?

Oh yeah updated - as for the block, it depends currently on bug 1173089 which blocks 1139482. We could add the block here but it seems redundant maybe?

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Jen Fong-Adwent [:ednapiranha] from comment #5)
> (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> > Also, should this bug block the meta bug then?
> 
> Oh yeah updated - as for the block, it depends currently on bug 1173089
> which blocks 1139482. We could add the block here but it seems redundant
> maybe?

Okay, up to you then...  I only wondered since the meta bug mentioned this tasks specifically in its title.

Comment 7

[Jen Fong-Adwent [:ednapiranha]]

Closing, since we will not be using the toggle buttons as per discussion. This will be reopened as other future bugs.