1173144 - [EME] Plugin voucher sometimes disappears

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Adobe have reported errors where the plugin voucher is not available at runtime. The .info and .dll files are available, we check they're there before starting up the GMP process, and the plugin-container voucher must be there too, but at runtime Adobe's GMP is unable to read their plugin voucher.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Ensure Adobe EME plugin voucher is present before adding GMP dir to GMPService.

I have no idea how the voucher could be missing from disk but the CDM DLL not be, so add a work around; ensure that the EME Plugin Voucher is present before adding the Adobe EME plugin dir to the GMPService. Basically this is the same tests we do for the DLL and .info files.

Comment 2

[Joe Steele]

Can we also verify that the .info file is present? It would be awkward if the CDM still loads in that case but does not have the supplemental DLLs it needs to run correctly.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Joe Steele from comment #2)
> Can we also verify that the .info file is present? It would be awkward if
> the CDM still loads in that case but does not have the supplemental DLLs it
> needs to run correctly.

We already do that. :)

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 8621348 [details] [diff] [review]
Patch: Ensure Adobe EME plugin voucher is present before adding GMP dir to GMPService.

Review of attachment 8621348 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder about things like "shouldn't this use async file IO" [.exists() can cause jank] and "should we have more specific telemetry for each case", but this looks like a trivial improvement to the status quo.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62da079a46b1

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 8621348 [details] [diff] [review]
Patch: Ensure Adobe EME plugin voucher is present before adding GMP dir to GMPService.

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: May help with reducing CDM error rates, where a broken local install causes breakage. This should catch such abnormal conditions, and allow a site to fallback to other mechanisms.
[Describe test coverage new/current, TreeHerder]: AFAIK there's other general coverage of this feature, but the change here is highly specific to the Adobe CDM.
[Risks and why]: Seems very low risk to me, and is just extending an existing check to cover more abnormal conditions.
[String/UUID change made/needed]: n/a

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/6e32a2128735 for https://treeherder.mozilla.org/logviewer.html#?job_id=10748985&repo=mozilla-inbound

Comment 8

[Justin Dolske [:Dolske]]

TEST-UNEXPECTED-FAIL | all-test-dirs.list:toolkit/mozapps/extensions/test/xpcshell/test_gmpProvider.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | all-test-dirs.list:toolkit/mozapps/extensions/test/xpcshell/test_gmpProvider.js | test_pluginRegistration - [test_pluginRegistration : 316] -1 != -1 

This is failing on Linux and Windows (and locally on OS X)...

308     // Create dummy GMP library/info files, and test that plugin registration
309     // succeeds during startup, now that we've added GMP info/lib files.
310     createMockPluginFilesIfNeeded(file, addon.id);
311 
312     gPrefs.setCharPref(gGetKey(GMPScope.GMPPrefs.KEY_PLUGIN_VERSION, addon.id),
313                        TEST_VERSION);
314     clearPaths();
315     yield promiseRestartManager();
316     Assert.notEqual(addedPaths.indexOf(file.path), -1);

file.path == [...]/xpc-profile-pbbBM4/gmp-eme-adobe/1.2.3.4
addedPaths == [...]xpc-profile-pbbBM4/gmp-gmpopenh264/1.2.3.4,/Users/dolske/build/mozilla-central/obj/dist/FirefoxDebug.app/Contents/Resources/gmp-clearkey/0.1

The Adobe CDM shouldn't even be on OS X, so I guess our tests are simulating it? Looks like createMockPluginFilesIfNeeded() probably needs to create a .voucher file too?

Comment 9

[Justin Dolske [:Dolske]]

Attachment: With test fix

Test passes locally for me with this test fix to create a dummy .voucher file.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32d0293e45be

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Try looks good, thanks for helping out dolske!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51be9af6ca00

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/51be9af6ca00

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8621348 [details] [diff] [review]
Patch: Ensure Adobe EME plugin voucher is present before adding GMP dir to GMPService.

Approved for uplift to aurora and beta.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d0d6aa6c7ace

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/05b522f50491