1173225 - [EME] Add override to GMPVideoDecoderTrialCreator

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

It would be handy for debugging purposes to have a pref that can reset the "we've tried to create a GMPVideoDecoder already" state, so that we always try. This means we don't have to reset it every time we're making a change during debugging.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Add a hidden pref "media.gmp.always-trial-create" to cause us to always trial create, if it's true. Default behaviour not changed.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c5e780dc36c

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c5e780dc36c

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8617703 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: EME/bug 1169129
[User impact if declined]: Negligible. This makes testing bug 1169129 easier, so makes it easier for us to be sure that bug 1169129 introduced no regressions.
[Describe test coverage new/current, TreeHerder]: We have lots of tests for EME
[Risks and why]: Low; adds a hidden pref.
[String/UUID change made/needed]: None.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8617703 [details] [diff] [review]
Patch

Anything to help with testing.
taking it

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e65911fe2bec