Closed Bug 1173225 Opened 5 years ago Closed 5 years ago

[EME] Add override to GMPVideoDecoderTrialCreator

Categories

(Core :: Audio/Video, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It would be handy for debugging purposes to have a pref that can reset the "we've tried to create a GMPVideoDecoder already" state, so that we always try. This means we don't have to reset it every time we're making a change during debugging.
Attached patch PatchSplinter Review
Add a hidden pref "media.gmp.always-trial-create" to cause us to always trial create, if it's true. Default behaviour not changed.
Attachment #8617703 - Flags: review?(edwin)
https://hg.mozilla.org/mozilla-central/rev/1c5e780dc36c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Flags: needinfo?(cpearce)
Comment on attachment 8617703 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: EME/bug 1169129
[User impact if declined]: Negligible. This makes testing bug 1169129 easier, so makes it easier for us to be sure that bug 1169129 introduced no regressions.
[Describe test coverage new/current, TreeHerder]: We have lots of tests for EME
[Risks and why]: Low; adds a hidden pref.
[String/UUID change made/needed]: None.
Attachment #8617703 - Flags: approval-mozilla-aurora?
Comment on attachment 8617703 [details] [diff] [review]
Patch

Anything to help with testing.
taking it
Attachment #8617703 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.