Closed Bug 1173248 Opened 5 years ago Closed 5 years ago

Remove the workaround introduced to MDSM by bug 951278

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/diff/116406daf772/content/media/MediaDecoderStateMachine.cpp

The change to MDSM is a workaround to avoid genlock_lock_buffer error on Unagi.

https://bugzilla.mozilla.org/show_bug.cgi?id=951278#c16

The genlock_lock_buffer error happened on Unagi only. I think we can now remove the workaround since MediaDecoderStateMachine::RenderVideoFrame() checks to ensure duplicated and invalid frames are not rendered.
Depends on: 951278
I did a simple RTSP test on flame-kk which worked fine. We should remove such workarounds which obscure the code.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8620849 - Flags: review?(cpearce)
Attachment #8620849 - Flags: review?(cpearce) → review+
Thanks for the review.
https://hg.mozilla.org/mozilla-central/rev/e5ea732b4531
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.