1173248 - Remove the workaround introduced to MDSM by bug 951278

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/diff/116406daf772/content/media/MediaDecoderStateMachine.cpp

The change to MDSM is a workaround to avoid genlock_lock_buffer error on Unagi.

https://bugzilla.mozilla.org/show_bug.cgi?id=951278#c16

The genlock_lock_buffer error happened on Unagi only. I think we can now remove the workaround since MediaDecoderStateMachine::RenderVideoFrame() checks to ensure duplicated and invalid frames are not rendered.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try looks green. https://treeherder.mozilla.org/#/jobs?repo=try&revision=d94d06d17deb

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1173248_remove_workaround-v1.patch

I did a simple RTSP test on flame-kk which worked fine. We should remove such workarounds which obscure the code.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5ea732b4531

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e5ea732b4531