[Contacts][NGA] Move 'updatePhoto' out of contacts.js in order to be reusable.

RESOLVED FIXED in Firefox OS master

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: borjasalguero, Assigned: fcampo)

Tracking

unspecified
NGA S2 (12Jun)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master fixed)

Details

(Whiteboard: [NG Gaia Contacts])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This affects 'form.js' & 'detail.js'
(Reporter)

Updated

3 years ago
Blocks: 1169191
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → NGA S2 (12Jun)
(Assignee)

Updated

3 years ago
Assignee: nobody → fernando.campo
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8619743 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/30523
Attachment #8619743 - Flags: review?(francisco)
Attachment #8619743 - Flags: review?(borja.bugzilla)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8619743 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/30523

Hi Fernando! I would move this to 'utilities/dom.js' due to it's something related with DOM, and we save one request for loading an additional file. Let me know when ready and I'll take a look again! Thanks!
Attachment #8619743 - Flags: review?(borja.bugzilla)
(Reporter)

Updated

3 years ago
Attachment #8619743 - Flags: review+
Comment on attachment 8619743 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/30523

Tested on the phone, lgtm.

Thanks Fernando!
Attachment #8619743 - Flags: review?(francisco) → review+
Keywords: checkin-needed
Seems the bot is not picking this change.

Landed manually:

https://github.com/mozilla-b2g/gaia/commit/567df2317c576407ea6ab4ee098047537b3c50d9

Thanks Fernando.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
status-b2g-master: --- → fixed
You need to log in before you can comment on or make changes to this bug.