1173268 - [Contacts][NGA] Move 'updatePhoto' out of contacts.js in order to be reusable.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Borja Salguero [:borjasalguero]]

This affects 'form.js' & 'detail.js'

Comment 1

[Fernando Campo (:fcampo)]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/30523

Comment 2

[Borja Salguero [:borjasalguero]]

Comment on attachment 8619743 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/30523

Hi Fernando! I would move this to 'utilities/dom.js' due to it's something related with DOM, and we save one request for loading an additional file. Let me know when ready and I'll take a look again! Thanks!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8619743 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/30523

Tested on the phone, lgtm.

Thanks Fernando!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Seems the bot is not picking this change.

Landed manually:

https://github.com/mozilla-b2g/gaia/commit/567df2317c576407ea6ab4ee098047537b3c50d9

Thanks Fernando.

Comment 5

[Kevin Grandon :kgrandon]

Seems this introduced a linter error. Seemed easy to resolve, so landed a follow-up here: https://github.com/mozilla-b2g/gaia/commit/ea88dde7648d2c6c0de354682e17590fca50e4e2

https://tools.taskcluster.net/task-inspector/#BEK8LLmDS9eo5v17nMCGCg/0