1173272 - MediaCodecReader: testcase test_can_play_type_webm.html failed.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Benjamin Chen [:bechen]]

Enable MediaCodecReader on emulator-kk build.

1307 INFO TEST-OK | dom/media/test/test_can_play_type_wave.html | took 1629ms
1308 INFO TEST-START | dom/media/test/test_can_play_type_webm.html
1309 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | A valid string reason is expected 
1310 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | Reason cannot be empty 
1311 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | video/webm 
1312 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | audio/webm 
1313 INFO android version:3.0.0.0-prerelease
1314 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | audio/webm; codecs=vorbis 
1315 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | video/webm; codecs=vorbis 
1316 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | audio/webm; codecs=opus - got , expected probably
1317 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs=opus - got , expected probably
1318 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | video/webm; codecs=vp8 
1319 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vp8, vorbis" 
1320 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vorbis, vp8" 
1321 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vp8, opus" - got , expected probably
1322 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="opus, vp8" - got , expected probably
1323 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | video/webm; codecs=vp8.0 
1324 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vp8.0, vorbis" 
1325 INFO TEST-PASS | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vorbis, vp8.0" 
1326 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vp8.0, opus" - got , expected probably
1327 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="opus, vp8.0" - got , expected probably
1328 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs=vp9 - got , expected probably
1329 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vp9, vorbis" - got , expected probably
1330 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vorbis, vp9" - got , expected probably
1331 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vp9, opus" - got , expected probably
1332 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="opus, vp9" - got , expected probably
1333 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs=vp9.0 - got , expected probably
1334 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vp9.0, vorbis" - got , expected probably
1335 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vorbis, vp9.0" - got , expected probably
1336 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="vp9.0, opus" - got , expected probably
1337 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_webm.html | video/webm; codecs="opus, vp9.0" - got , expected probably

Comment 1

[Benjamin Chen [:bechen]]

In DecoderTraits.cpp:

#ifdef MOZ_OMX_WEBM_DECODER
    } else if (nsDependentCString(aMIMEType).EqualsASCII("audio/webm") ||
               nsDependentCString(aMIMEType).EqualsASCII("video/webm")) {
      codecList = gOMXWebMCodecs;
#endif

#ifdef MOZ_OMX_WEBM_DECODER
static char const *const gOMXWebMCodecs[4] = {
  "vorbis",
  "vp8",
  "vp8.0",
  nullptr
};

Comment 2

[Benjamin Chen [:bechen]]

Look into nsSystemInfo.cpp.
"sdk_version" and "version" seems different..........
 
 var androidVer = SpecialPowers.Cc['@mozilla.org/system-info;1']
                                  .getService(SpecialPowers.Ci.nsIPropertyBag2)
                                  .getProperty('version');
                                               ^^^^^^^^^^
We should use "sdk_version".

Comment 4

[Benjamin Chen [:bechen]]

Attachment: bug-1173272.v01.patch

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8621502 [details] [diff] [review]
bug-1173272.v01.patch

Review of attachment 8621502 [details] [diff] [review]:
-----------------------------------------------------------------

Isn't it better to make clear more that it is for gonk's sdk? The code seems a bit confusing. On android, 'version' seems to store sdk version.
https://dxr.mozilla.org/mozilla-central/source/xpcom/base/nsSystemInfo.cpp#355

Comment 6

[Benjamin Chen [:bechen]]

Attachment: bug-1173272.v02.patch

dom/contacts/tests/shared.js and dom/media/test/manifest.js have the same issue.

(In reply to Sotaro Ikeda [:sotaro] from comment #5)
> Comment on attachment 8621502 [details] [diff] [review]
> bug-1173272.v01.patch
> 
> Review of attachment 8621502 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Isn't it better to make clear more that it is for gonk's sdk? The code seems
> a bit confusing. On android, 'version' seems to store sdk version.

Do you mean that we should modify the nsSystemInfo.cpp or comment it? Or just wurite some comments in testcase?

Comment 7

[Sotaro Ikeda [:sotaro]]

Sorry, my comment was not clear. Just write some comments in testcase is enough.

Comment 8

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8622898 [details] [diff] [review]
bug-1173272.v02.patch

review+ by adding more comments to make clear the confusion between android sdk version and gonk's sdk version.

Comment 9

[Benjamin Chen [:bechen]]

Attachment: bug-1173272.v02.patch

r=sotaro
I revert the change for shared.js because the code piece is for Android.

try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b933970ae6c

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3faf3368ce6f

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3faf3368ce6f