Closed Bug 1173390 Opened 5 years ago Closed 5 years ago

Remove old directory picker implementation

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Much of the code that was added by the bugs blocking bug 846931 no longer works after the conversion to e10s, and would need to be written very differently to fix it.

The directory picker behavior that we implemented under that bug is also very different to the directory picker behavior being implemented under bug 1164310. We should just remove this implementation.
Attached patch patchSplinter Review
Attachment #8620381 - Flags: review?(jonas)
Comment on attachment 8620381 [details] [diff] [review]
patch

Andrea, would you be able to review this?
Attachment #8620381 - Flags: review?(jonas) → review?(amarchesini)
Comment on attachment 8620381 [details] [diff] [review]
patch

Review of attachment 8620381 [details] [diff] [review]:
-----------------------------------------------------------------

funny, we have no tests at all about all this code.
Attachment #8620381 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/cd23b6aa0918
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.