Closed
Bug 1173390
Opened 10 years ago
Closed 10 years ago
Remove old directory picker implementation
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
23.07 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Much of the code that was added by the bugs blocking bug 846931 no longer works after the conversion to e10s, and would need to be written very differently to fix it.
The directory picker behavior that we implemented under that bug is also very different to the directory picker behavior being implemented under bug 1164310. We should just remove this implementation.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8620381 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8620381 [details] [diff] [review]
patch
Andrea, would you be able to review this?
Attachment #8620381 -
Flags: review?(jonas) → review?(amarchesini)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8620381 [details] [diff] [review]
patch
Review of attachment 8620381 [details] [diff] [review]:
-----------------------------------------------------------------
funny, we have no tests at all about all this code.
Attachment #8620381 -
Flags: review?(amarchesini) → review+
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•