1173522 - Tie "Factory Reset and Enable Full DevTools" toggle into "full-developer-mode" flow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Doug Sherk (:drs) (inactive)]

The flow that was introduced in bug 1163889 for enabling DM works really well. It's great that we have a toggle now in the Developer menu, but it doesn't seem to do everything that the "full-developer-mode" activity does. The warning text that the "full-developer-mode" dialog generates is also much more explicit and fear-inspiring.

To solve both of these problems, let's just tie the toggle button into the same flow as the activity.

Comment 1

[Doug Sherk (:drs) (inactive)]

Yura, Arthur, could one of you take this please?

Comment 2

[Doug Sherk (:drs) (inactive)]

Yura raised a point that this dialog doesn't make sense for disabling DM. We could use the existing flow for the disable scenario, instead.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

I can help on this one.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/30562

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8622184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30562

EJ, could you help on review the patch when you get a chance?

I was trying to reuse the dialogs and warnings implemented in bug 1163889 but found that impossible due to limitations on how settings app handles an activity. Then I turned to create a duplicate dialog for the current use case. Let me know should any concerns, thanks!

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8622184 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30562

Thanks Arthur, r+ for this patch

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ!

master: c65396dbaee27addf7efce94315951585bb13bf3