Closed Bug 1173522 Opened 4 years ago Closed 4 years ago

Tie "Factory Reset and Enable Full DevTools" toggle into "full-developer-mode" flow


(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Gonk (Firefox OS)


(Not tracked)



(Reporter: drs, Assigned: arthurcc)



(Whiteboard: [spark])


(1 file)

The flow that was introduced in bug 1163889 for enabling DM works really well. It's great that we have a toggle now in the Developer menu, but it doesn't seem to do everything that the "full-developer-mode" activity does. The warning text that the "full-developer-mode" dialog generates is also much more explicit and fear-inspiring.

To solve both of these problems, let's just tie the toggle button into the same flow as the activity.
Yura, Arthur, could one of you take this please?
Flags: needinfo?(yzenevich)
Flags: needinfo?(arthur.chen)
Yura raised a point that this dialog doesn't make sense for disabling DM. We could use the existing flow for the disable scenario, instead.
I can help on this one.
Assignee: nobody → arthur.chen
Flags: needinfo?(yzenevich)
Flags: needinfo?(arthur.chen)
Comment on attachment 8622184 [details]
link to

EJ, could you help on review the patch when you get a chance?

I was trying to reuse the dialogs and warnings implemented in bug 1163889 but found that impossible due to limitations on how settings app handles an activity. Then I turned to create a duplicate dialog for the current use case. Let me know should any concerns, thanks!
Attachment #8622184 - Flags: review?(eragonj+moz)
Comment on attachment 8622184 [details]
link to

Thanks Arthur, r+ for this patch
Attachment #8622184 - Flags: review?(eragonj+moz) → review+
Thanks, EJ!

master: c65396dbaee27addf7efce94315951585bb13bf3
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.