1173558 - DevToolsUtils.safeErrorString should have a better fallback

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

We give a string saying that we failed to get a description if .toString() fails, but we should just use Object.prototype.toString.call(aError) instead.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Give a better last ditch fallback to DevToolsUtils.safeErrorString

Comment 2

[James Long (:jlongster)]

Comment on attachment 8620642 [details] [diff] [review]
Give a better last ditch fallback to DevToolsUtils.safeErrorString

Review of attachment 8620642 [details] [diff] [review]:
-----------------------------------------------------------------

Absolutely.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9807fb275ecf

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9807fb275ecf