Closed
Bug 1173558
Opened 11 years ago
Closed 11 years ago
DevToolsUtils.safeErrorString should have a better fallback
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
|
1.63 KB,
patch
|
jlong
:
review+
|
Details | Diff | Splinter Review |
We give a string saying that we failed to get a description if .toString() fails, but we should just use Object.prototype.toString.call(aError) instead.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8620642 -
Flags: review?(jlong)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8620642 [details] [diff] [review]
Give a better last ditch fallback to DevToolsUtils.safeErrorString
Review of attachment 8620642 [details] [diff] [review]:
-----------------------------------------------------------------
Absolutely.
Attachment #8620642 -
Flags: review?(jlong) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
|
||
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•