DevToolsUtils.safeErrorString should have a better fallback

RESOLVED FIXED in Firefox 41

Status

()

Firefox
Developer Tools
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
Firefox 41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

We give a string saying that we failed to get a description if .toString() fails, but we should just use Object.prototype.toString.call(aError) instead.
Created attachment 8620642 [details] [diff] [review]
Give a better last ditch fallback to DevToolsUtils.safeErrorString
Attachment #8620642 - Flags: review?(jlong)
Comment on attachment 8620642 [details] [diff] [review]
Give a better last ditch fallback to DevToolsUtils.safeErrorString

Review of attachment 8620642 [details] [diff] [review]:
-----------------------------------------------------------------

Absolutely.
Attachment #8620642 - Flags: review?(jlong) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9807fb275ecf
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.