117374 - UpdateSpaceManager no longer needed

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There was apparently a long thread on the performance newsgroups about
UpdateSpaceManager of which I was not informed.  I think this function is no
longer needed as a result of my changes for bug 86947 and bug 106658, but I
neglected to remove it.  As a result of the changes in those two bugs,
nsBlockReflowState::RecoverFloaters should be doing all the work that
UpdateSpaceManager did.  (It used to be that SlideLine was called from a
different point in the code -- I'm not in the mood to figure out how things used
to work, but it probably used to make sense, except that the code in
RecoverFloaters was duplicating some addition to the space manager that had
already happened in UpdateSpaceManager at the wrong coordinates.)  I also caught
what I think is a bug in RecoverFloaters that was causing some bugs on misplaced
floats that I've seen -- it should have been passing a 0 aDeltaY for the
recursive calls, I think.

However, I'm going to test the patch before I attach it... :-)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch fixing this bug and bug 113895

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: slightly cleaner (prefer GetOrigin/MoveTo over GetRect/SetRect)

Comment 3

[Chris Waterson]

Comment on attachment 63030 [details] [diff] [review]
slightly cleaner (prefer GetOrigin/MoveTo over GetRect/SetRect)

r=/sr=waterson

Comment 4

[Marc Attinasi]

Comment on attachment 63030 [details] [diff] [review]
slightly cleaner (prefer GetOrigin/MoveTo over GetRect/SetRect)

r=attinasi

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2002-01-06 10:14 PDT.